Merged
Conversation
Contributor
Author
|
I think this feature is ready for review besides maybe some tweaks to the physics. And since I'm working in this item I want to double check that some of the behavior is still what we want: #720 (comment) (linking this here for continuity) The bomb will explode on collision with a sliding player or a player's back. I'm not sure if that second part was done because only bouncing off the front of a player makes the logic simpler, but if that's no longer desired I can fix that here too :) |
Member
|
I think this is good! I'm pretty sure it's supposed to explode off of the back of a player, since they can't reasonably kick it when it's behind them ( maybe 🤷♂️ ), but if we want to change that later we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #720
Changes