Add Jellyfish weapon#36
Merged
not-fl3 merged 12 commits intofishfolk:masterfrom Jul 25, 2021
64kramsystem:sav/add_jellyfish_weapon
Merged
Add Jellyfish weapon#36not-fl3 merged 12 commits intofishfolk:masterfrom 64kramsystem:sav/add_jellyfish_weapon
not-fl3 merged 12 commits intofishfolk:masterfrom
64kramsystem:sav/add_jellyfish_weapon
Conversation
This way, weapons can poll the last input.
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This weapon turned out to be complex, not in algorithmic terms, but in terms of states handling and general coupling.
Additionally, it will likely require tweaking once it's decided how certain aspect should behave (for example, should the floating JF always move sideways if there is no space to jump?).
There are two global changes in this PR:
remote_controlfield to the player, which disables the input when setWith a better knowledge of the project and/or MQ, there may be simplifications.
A design choice has been to handle all the state logic via Jellyfish methods; if that logic is spread out, it may be very messy to track.
jellyfish.mp4