Skip to content

Add Jellyfish weapon#36

Merged
not-fl3 merged 12 commits intofishfolk:masterfrom
64kramsystem:sav/add_jellyfish_weapon
Jul 25, 2021
Merged

Add Jellyfish weapon#36
not-fl3 merged 12 commits intofishfolk:masterfrom
64kramsystem:sav/add_jellyfish_weapon

Conversation

@64kramsystem
Copy link
Member

@64kramsystem 64kramsystem commented Jul 25, 2021

This weapon turned out to be complex, not in algorithmic terms, but in terms of states handling and general coupling.
Additionally, it will likely require tweaking once it's decided how certain aspect should behave (for example, should the floating JF always move sideways if there is no space to jump?).

There are two global changes in this PR:

  1. Addition of the remote_control field to the player, which disables the input when set
  2. Made Input and its fields public; this allows weapons to poll the controls, without the Player type being aware of the weapon

With a better knowledge of the project and/or MQ, there may be simplifications.

A design choice has been to handle all the state logic via Jellyfish methods; if that logic is spread out, it may be very messy to track.

jellyfish.mp4

@64kramsystem 64kramsystem changed the title This weapon turned out to be complex, not in algorithmic terms, but in terms of states handling and general coupling. Additionally, it will likely require tweaking once it's decided how certain aspect should behave (for example, should the floating JF always move sideways if there is no space to jump?). Add Jellyfish weapon Jul 25, 2021
@not-fl3 not-fl3 merged commit 57bc3db into fishfolk:master Jul 25, 2021
@not-fl3 not-fl3 deleted the sav/add_jellyfish_weapon branch July 25, 2021 21:44
@erlend-sh erlend-sh added the topic:item Interactive items, e.g. equipment label Sep 14, 2021
@erlend-sh erlend-sh mentioned this pull request Dec 30, 2022
@zicklag zicklag mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:item Interactive items, e.g. equipment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants