Skip to content

Conversation

@kidonng
Copy link
Contributor

@kidonng kidonng commented Nov 16, 2021

Description

The checks probably won't hurt but are unnecessary after all.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho
Copy link
Member

faho commented Nov 16, 2021

Sorry, no, this is our entire test suite. It runs a bunch of tests that run our functions. It is necessary.

@faho faho closed this Nov 16, 2021
@faho faho added this to the will-not-implement milestone Nov 16, 2021
@kidonng
Copy link
Contributor Author

kidonng commented Nov 16, 2021

Alright, but the name is pretty confusing. Maybe make it more generic, e.g. just "Tests" or "CI"?

@faho
Copy link
Member

faho commented Nov 16, 2021

Sure, why not. I just took the name from some example to build C++.

@kidonng kidonng mentioned this pull request Nov 16, 2021
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants