ci: silence 429s errors in link checker#10495
Merged
thomaseizinger merged 1 commit intomainfrom Oct 1, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the CI link checker configuration to silence HTTP 429 (Too Many Requests) errors as a temporary workaround until a proper fix is available upstream.
- Updates the lychee link checker arguments to accept 429 status codes as valid responses
klochowicz
approved these changes
Oct 1, 2025
| with: | ||
| fail: false | ||
| args: --verbose --no-progress --exclude-all-private --max-concurrency 1 --retry-wait-time 60 --base https://firezone.dev . | ||
| args: --verbose --no-progress --exclude-all-private --max-concurrency 1 --retry-wait-time 60 --base https://firezone.dev --accept 100..=103,200..=299,429 . |
Collaborator
There was a problem hiding this comment.
nitpick: it would be good to add a FIXME to remove accepting 429's when the condition changes, so that we won't forget about it (and e.g. IDE can help us)
Member
Author
There was a problem hiding this comment.
I am subscribed to the PR and will fix it once that lands!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until lycheeverse/lychee#1844 is shipped, we silence 429s as valid status codes whenever links are being checked by lychee.