jailer: Ensure that bindmounts are propagated into the root#1093
Merged
alxiord merged 2 commits intofirecracker-microvm:masterfrom May 20, 2019
Merged
jailer: Ensure that bindmounts are propagated into the root#1093alxiord merged 2 commits intofirecracker-microvm:masterfrom
alxiord merged 2 commits intofirecracker-microvm:masterfrom
Conversation
This was referenced May 13, 2019
alexandruag
reviewed
May 14, 2019
42e4f4c to
fc99e0d
Compare
petreeftime
previously approved these changes
May 17, 2019
User can bind mount into the chroot location. This is needed as hard links cannot cross file system boundaries. Copy is not always feasible (e.g. block devices). Change the bind mount to be slave, such that host to jail bind mounts are properly propagated. However we do not want to jail to host events to propgate back. Fixes: firecracker-microvm#1089 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
fc99e0d to
9661a85
Compare
alexandruag
approved these changes
May 19, 2019
alxiord
approved these changes
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can bind mount into the chroot location.
This is needed as hard links cannot cross file system boundaries.
Copy is not always feasible (e.g. block devices).
Change the bind mount to be slave, such that host to jail bind
mounts are properly propagated. However we do not want to jail
to host events to propgate back.
Fixes: #1089
Signed-off-by: Manohar Castelino manohar.r.castelino@intel.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.