Skip to content

Fix armhf build with 64 bit time and file offset representation#1277

Merged
rbalint merged 4 commits intofirebuild:masterfrom
rbalint:fix-armhf-time64
May 2, 2024
Merged

Fix armhf build with 64 bit time and file offset representation#1277
rbalint merged 4 commits intofirebuild:masterfrom
rbalint:fix-armhf-time64

Conversation

@rbalint
Copy link
Collaborator

@rbalint rbalint commented May 2, 2024

No description provided.

rbalint added 4 commits May 2, 2024 20:43
instead of relying on undefining potential renaming macros.

This helps with really fixing the symbol name on armhf after the time64
transition which redirects many functions.

See:
 https://wiki.debian.org/ReleaseGoals/64bit-time
 https://www.gnu.org/software/libc/manual/html_node/64_002dbit-time-symbol-handling.html
 https://musl.libc.org/time64.html
…et on 32bit systems

This fixes build problems on Ubuntu 24.04 armhf systems.

Improves firebuild#161.
…_ic_orig_*()

Those are the safe choice on 32 bit systems, such as armhf after the transition
to use 64bit time and file offsets everywhere.

Improves firebuild#161.
… symbol variants

This guards against accidentally misusing 32 bit parameters or return values
when the interceptor is compiled with 64bit time and file offset representation.

Improves firebuild#162.
@rbalint rbalint merged commit b27cd5e into firebuild:master May 2, 2024
@rbalint rbalint deleted the fix-armhf-time64 branch May 2, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant