fix(firebase_ui_auth): Error added in ProfileScreen in firebase_ui_auth 1.4.0 (#10957)

zachary-russell · web-flow · commit 12284b3b0b98 · 2023-05-17T18:49:29.000+02:00
* Fix  Error:

* fix(test): get tests to pass

The prefer_const_constructors warning is ignored in this case because the LoadingIndicator widget used inside the children list of the Row does not have a const constructor. This is due to the fact that LoadingIndicator extends PlatformWidget, which doesn't have a const constructor, making it impossible to have a const constructor for LoadingIndicator. Since we can't make the LoadingIndicator constructor const, we have to ignore the warning for the specific Row constructor. This is an acceptable solution in cases like this, where making the constructor const is not feasible or possible.

* fix: revert changes
diff --git a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart
@@ -390,9 +390,10 @@ class _EmailVerificationBadgeState extends State<_EmailVerificationBadge> {
           ),
           const SizedBox(height: 16),
           if (state == EmailVerificationState.pending)
-            const Row(
+            // ignore: prefer_const_constructors
+            Row(
               mainAxisAlignment: MainAxisAlignment.center,
-              children: [
+              children: const [
                 LoadingIndicator(size: 16, borderWidth: 0.5),
                 SizedBox(width: 16),
                 Text('Waiting for email verification'),
