feat(firestore): add accumulators expressions#9576
Conversation
🦋 Changeset detectedLatest commit: e146415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @yvonnep165, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Firestore's aggregation capabilities by introducing several new accumulator expressions. These additions provide developers with more powerful tools to perform complex data manipulations, such as retrieving specific elements from ordered sets or collecting values into arrays, directly within their database queries. The changes are fully documented and thoroughly tested to ensure reliability and ease of use. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces four new accumulator expressions: first, last, arrayAgg, and arrayAggDistinct. These are implemented as methods on the Expression class and as top-level functions, following the existing patterns in the SDK. Integration tests for both the standard and lite versions of the SDK are included, covering various scenarios and ensuring correctness. Documentation and API reports are also updated accordingly. The implementation is solid and follows established conventions.
Add new accumulators expressions
first,last,array_agg,array_agg_distinctand integration tests for the four expressions