fix(ai): Fix logic for merging onDeviceParams#9314
Merged
Conversation
🦋 Changeset detectedLatest commit: 907badd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
erikeldridge
approved these changes
Oct 10, 2025
| expectedInputs: [{ type: 'image' }] | ||
| }); | ||
| }); | ||
| it('sets image as expected input type by default even if other onDeviceParams params are set', async () => { |
Contributor
There was a problem hiding this comment.
Seems we should also test the case where expectedInputs are passed in and replace the default expectedInputs
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
dlarocque
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-provided onDeviceParams should do a union merge with default onDeviceParams (default only contains a single value nested 2 levels down - onDeviceParams.createOptions.expectedInputs). In the case that the user explicitly specifies a value for
expectedInputs, the user's value should override the default.