Skip to content

ci: Reorder reporters to prevent log message duplication#9040

Merged
MarkDuckworth merged 1 commit intomainfrom
markduckworth/fix-duplicate-console-logging
May 22, 2025
Merged

ci: Reorder reporters to prevent log message duplication#9040
MarkDuckworth merged 1 commit intomainfrom
markduckworth/fix-duplicate-console-logging

Conversation

@MarkDuckworth
Copy link
Contributor

Reorder reporters in karma config to prevent log message duplication. Currently in CI actions that run Karma, all SDK logging is rendered twice (example). This fixes the issue.

See also: karma-runner/karma#2342 (comment)

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner May 14, 2025 18:50
@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 6289324

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@MarkDuckworth MarkDuckworth changed the title chore: Reorder reporters to prevent log message duplication ci: Reorder reporters to prevent log message duplication May 14, 2025
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! This always bothered me but I was never able to find the source of it.

@google-oss-bot
Copy link
Collaborator

@google-oss-bot
Copy link
Collaborator

Size Analysis Report 1

Affected Products

No changes between base commit (799de59) and merge commit (25d7081).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vuENOQBb8v.html

@dlarocque
Copy link
Contributor

ty!

@MarkDuckworth MarkDuckworth merged commit d5e5795 into main May 22, 2025
49 of 53 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/fix-duplicate-console-logging branch May 22, 2025 18:17
@firebase firebase locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants