Add Cookie Support For Firebase Studio by maneesht · Pull Request #8986 · firebase/firebase-js-sdk

maneesht · 2025-04-29T22:41:53Z

Currently, when you have a new tab in Firebase Studio, it isn't able to get the cloud workstation's auth cookie, which can cause a redirect.
As a way to bypass this, the Firebase Studio team recommended that we make a request out to each emulator when it is connected to. This PR makes that change.

…s-use-emulat9or

…om/firebase/firebase-js-sdk into mtewani/auto-ssl-cloudworkstations

changeset-bot · 2025-04-29T22:41:56Z

⚠️ No Changeset found

Latest commit: 78a4fea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-04-29T22:42:08Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.0

github-actions · 2025-04-29T22:43:12Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2025-04-29T22:51:33Z

Size Report ¹

Affected Products

@firebase/auth
Type Base (0e12766) Merge (53507d1) Diff
browser 193 kB 193 kB +88 B (+0.0%)
cordova 166 kB 166 kB +88 B (+0.1%)
main 147 kB 147 kB +87 B (+0.1%)
module 193 kB 193 kB +88 B (+0.0%)
react-native 165 kB 165 kB +87 B (+0.1%)
@firebase/auth-cordova
Type Base (0e12766) Merge (53507d1) Diff
browser 166 kB 166 kB +88 B (+0.1%)
module 166 kB 166 kB +88 B (+0.1%)
@firebase/auth-web-extension
Type Base (0e12766) Merge (53507d1) Diff
browser 142 kB 142 kB +88 B (+0.1%)
main 159 kB 159 kB +91 B (+0.1%)
module 142 kB 142 kB +88 B (+0.1%)
@firebase/auth/internal
Type Base (0e12766) Merge (53507d1) Diff
browser 204 kB 204 kB +88 B (+0.0%)
main 174 kB 174 kB +91 B (+0.1%)
module 204 kB 204 kB +88 B (+0.0%)
@firebase/data-connect
Type Base (0e12766) Merge (53507d1) Diff
browser 21.6 kB 21.7 kB +96 B (+0.4%)
main 23.8 kB 23.9 kB +95 B (+0.4%)
module 21.6 kB 21.7 kB +96 B (+0.4%)
@firebase/database
Type Base (0e12766) Merge (53507d1) Diff
browser 249 kB 249 kB +62 B (+0.0%)
main 254 kB 254 kB +61 B (+0.0%)
module 249 kB 249 kB +62 B (+0.0%)
@firebase/database-compat/standalone
Type Base (0e12766) Merge (53507d1) Diff
main 366 kB 366 kB +61 B (+0.0%)
@firebase/firestore
Type Base (0e12766) Merge (53507d1) Diff
browser 384 kB 385 kB +99 B (+0.0%)
main 594 kB 595 kB +155 B (+0.0%)
module 384 kB 385 kB +99 B (+0.0%)
react-native 385 kB 385 kB +99 B (+0.0%)
@firebase/firestore-lite
Type Base (0e12766) Merge (53507d1) Diff
browser 114 kB 114 kB +43 B (+0.0%)
main 157 kB 157 kB +61 B (+0.0%)
module 114 kB 114 kB +43 B (+0.0%)
react-native 114 kB 114 kB +44 B (+0.0%)
@firebase/functions
Type Base (0e12766) Merge (53507d1) Diff
browser 14.0 kB 14.1 kB +73 B (+0.5%)
main 14.6 kB 14.7 kB +67 B (+0.5%)
module 14.0 kB 14.1 kB +73 B (+0.5%)
@firebase/storage
Type Base (0e12766) Merge (53507d1) Diff
browser 58.4 kB 58.4 kB +65 B (+0.1%)
main 59.9 kB 60.0 kB +59 B (+0.1%)
module 58.4 kB 58.4 kB +65 B (+0.1%)
@firebase/util
Type Base (0e12766) Merge (53507d1) Diff
browser 23.4 kB 23.5 kB +123 B (+0.5%)
main 29.5 kB 29.7 kB +193 B (+0.7%)
module 23.4 kB 23.5 kB +123 B (+0.5%)

`bundle`

34 size changes

Type	Base (`0e12766`)	Merge (53507d1)	Diff
auth (GoogleFBTwitterGitHubPopup)	105 kB	105 kB	+117 B (+0.1%)
database (Append to a list of data)	150 kB	150 kB	+104 B (+0.1%)
database (Filtering data)	149 kB	149 kB	+104 B (+0.1%)
database (Listen for child events)	165 kB	165 kB	+104 B (+0.1%)
database (Listen for value events + Detach listeners)	165 kB	165 kB	+104 B (+0.1%)
database (Listen for value events)	165 kB	165 kB	+104 B (+0.1%)
database (Read data once)	165 kB	165 kB	+104 B (+0.1%)
database (Save data as transactions)	167 kB	167 kB	+104 B (+0.1%)
database (Sort data)	150 kB	151 kB	+104 B (+0.1%)
database (Write data)	149 kB	149 kB	+104 B (+0.1%)
firestore (CSI Auto Indexing Disable and Delete)	275 kB	275 kB	+102 B (+0.0%)
firestore (CSI Auto Indexing Enable)	275 kB	275 kB	+102 B (+0.0%)
firestore (Persistence)	306 kB	306 kB	+102 B (+0.0%)
firestore (Query Cursors)	252 kB	252 kB	+104 B (+0.0%)
firestore (Query)	249 kB	249 kB	+104 B (+0.0%)
firestore (Read data once)	237 kB	237 kB	+104 B (+0.0%)
firestore (Read Write w Persistence)	331 kB	331 kB	+104 B (+0.0%)
firestore (Realtime updates)	239 kB	239 kB	+104 B (+0.0%)
firestore (Transaction)	216 kB	216 kB	+104 B (+0.0%)
firestore (Write data)	216 kB	216 kB	+104 B (+0.0%)
firestore-lite (Query Cursors)	105 kB	105 kB	+104 B (+0.1%)
firestore-lite (Query)	101 kB	101 kB	+104 B (+0.1%)
firestore-lite (Read data once)	76.2 kB	76.3 kB	+104 B (+0.1%)
firestore-lite (Transaction)	102 kB	102 kB	+104 B (+0.1%)
firestore-lite (Write data)	85.8 kB	85.9 kB	+104 B (+0.1%)
functions (call)	34.9 kB	35.0 kB	+113 B (+0.3%)
storage (getBytes)	42.7 kB	42.8 kB	+117 B (+0.3%)
storage (getDownloadURL)	44.8 kB	44.9 kB	+117 B (+0.3%)
storage (getMetadata)	44.2 kB	44.3 kB	+117 B (+0.3%)
storage (list + listAll)	43.6 kB	43.8 kB	+117 B (+0.3%)
storage (updateMetadata)	44.5 kB	44.6 kB	+117 B (+0.3%)
storage (uploadBytes)	49.3 kB	49.5 kB	+117 B (+0.2%)
storage (uploadBytesResumable)	59.3 kB	59.4 kB	+117 B (+0.2%)
storage (uploadString)	49.5 kB	49.7 kB	+117 B (+0.2%)

`firebase`

15 size changes

Type	Base (`0e12766`)	Merge (53507d1)	Diff
firebase-auth-compat.js	141 kB	141 kB	+105 B (+0.1%)
firebase-auth-cordova.js	138 kB	138 kB	+140 B (+0.1%)
firebase-auth-web-extension.js	121 kB	121 kB	+140 B (+0.1%)
firebase-auth.js	158 kB	158 kB	+140 B (+0.1%)
firebase-compat.js	797 kB	797 kB	+178 B (+0.0%)
firebase-data-connect.js	18.1 kB	18.2 kB	+152 B (+0.8%)
firebase-database-compat.js	164 kB	164 kB	+93 B (+0.1%)
firebase-database.js	187 kB	187 kB	+123 B (+0.1%)
firebase-firestore-compat.js	342 kB	342 kB	+72 B (+0.0%)
firebase-firestore-lite.js	133 kB	133 kB	+99 B (+0.1%)
firebase-firestore.js	443 kB	443 kB	+164 B (+0.0%)
firebase-functions-compat.js	10.5 kB	10.5 kB	+89 B (+0.9%)
firebase-functions.js	14.9 kB	15.0 kB	+126 B (+0.8%)
firebase-storage-compat.js	40.0 kB	40.1 kB	+77 B (+0.2%)
firebase-storage.js	46.6 kB	46.7 kB	+104 B (+0.2%)

Test Logs

Base (0e12766): https://github.com/firebase/firebase-js-sdk/actions/runs/14762570977
Merge (53507d1): https://github.com/firebase/firebase-js-sdk/actions/runs/14765331865

https://storage.googleapis.com/firebase-sdk-metric-reports/AehXuR30Tb.html

google-oss-bot · 2025-04-29T23:02:47Z

Size Analysis Report ¹

This report is too large (195,043 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

Base (0e12766): https://github.com/firebase/firebase-js-sdk/actions/runs/14762570977
Merge (53507d1): https://github.com/firebase/firebase-js-sdk/actions/runs/14765331865

https://storage.googleapis.com/firebase-sdk-metric-reports/C9PADahoSx.html

…pport-studio

maneesht and others added 30 commits April 11, 2025 14:30

Added test project to fdc

02c52c6

Fixed formatting

37d0f18

Fix linting

a4d7813

Excluded example integration from tsconfig

170b15a

Fixed example-integration package.json

ec405ae

Added ssl check for firestore

248f654

Added ssl checks for RTDB

14ef1bc

Merge remote-tracking branch 'origin/main' into mtewani/add-ssl-check…

a8fe7de

…s-use-emulat9or

Removed unnecessary files

df4a115

Removed unnecessary data connect changes

f867d3b

Create gentle-laws-kneel.md

4f23f33

Addressed feedback

e755d8c

Addressed linting issue

ceed5ab

Added functions change

44e2d8b

Removed linting rules

a1b85e2

Updated useEmulator

d67b284

Updated functions signatures

a8b208b

Updated docsite changes

205f9ca

Added tests

4bc9433

Updated docsite

a32ea8b

Fixed formatting

07f44b6

Only checked if user is on cloudworkstation for ssl

d305dec

Removed ssl from storage compat

fc6469a

Revert devsite changes

0a0cb7a

Added return type

25f8be9

Fixed tests

59ab583

Removed changeset

d473c45

Create nice-plants-thank.md

43b4d6d

Fixed test

5538911

Merge branch 'mtewani/auto-ssl-cloudworkstations' of https://github.c…

54f2d7a

…om/firebase/firebase-js-sdk into mtewani/auto-ssl-cloudworkstations

maneesht requested review from NhienLam, Xiaoshouzi-gh, aashishpatil-g, hsubox76, lisajian, mansisampat, pashanka, sam-gc and tonyjhuang as code owners April 29, 2025 22:41

Fixed linting issues

b439cca

maneesht added 8 commits April 29, 2025 16:23

Included credential forwarding

226be0b

Renamed function

d660fab

Merge remote-tracking branch 'origin/main' into mtewani/add-cookie-su…

e471cf7

…pport-studio

Removed app check changes

b3427c5

Removed the test changes

b95a71c

Fix formatting

58367e1

Fixed formatting

9edcd82

Added rtdb changes

9de2506

avolkovi approved these changes Apr 30, 2025

View reviewed changes

Updated comments

78a4fea

MarkDuckworth approved these changes Apr 30, 2025

View reviewed changes

hsubox76 approved these changes May 1, 2025

View reviewed changes

maneesht merged commit 080a90d into main May 1, 2025
44 of 49 checks passed

maneesht deleted the mtewani/add-cookie-support-studio branch May 1, 2025 01:49

firebase locked and limited conversation to collaborators Jun 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Cookie Support For Firebase Studio#8986

Add Cookie Support For Firebase Studio#8986
maneesht merged 70 commits intomainfrom
mtewani/add-cookie-support-studio

maneesht commented Apr 29, 2025

Uh oh!

changeset-bot bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Apr 29, 2025 •

edited

Loading

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

maneesht commented Apr 29, 2025

Uh oh!

changeset-bot bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Apr 29, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

github-actions bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

google-oss-bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/auth

@firebase/auth-cordova

@firebase/auth-web-extension

@firebase/auth/internal

@firebase/data-connect

@firebase/database

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/storage

@firebase/util

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Apr 29, 2025 •

edited

Loading

github-actions bot commented Apr 29, 2025 •

edited

Loading

google-oss-bot commented Apr 29, 2025 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Apr 29, 2025 •

edited

Loading

Size Analysis Report ¹