Conversation
🦋 Changeset detectedLatest commit: 3339ff3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Vertex AI Mock Responses Check
|
…se/firebase-js-sdk into mtewani/fix-private-error
Collaborator
Size Report 1Affected Products
Test Logs |
aashishpatil-g
approved these changes
Apr 4, 2025
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataConnectOperationErrorextendsDataConnectError, both of which have tags@hideconstructor. This means that in public builds, our output marks the constructors asprivate. However, this causes an error to be thrown:cannot extend private constructor, becauseDataConnectOperationErrorextendsDataConnectError, which has a private constructor. The reason why this wasn't caught during integration tests is because to integration tests, the constructors aren't private, but for public builds (that are used by external devs), the constructors are private. So the only way we could've caught this would've been to use the published version (or packaged version) of the SDK.TL;DR: Fix error where if we exported
DataConnectError, then when using the types, the user would get acannot extend private constructordue to the fact thatDataConnectOperationErrorwould extendDataConnectError.The fix for this is to remove the
@hideconstructorannotation. The right fix would have been to not exportDataConnectErrorat all, but if we do that, it would result in a breaking change for those who useDataConnectError. (Though, the argument can be made that no one is even able to use that type because the types are broken).