Skip to content

Converting bundle protos to Proto3 JSON compatible format#8855

Merged
DellaBitta merged 1 commit intoddb-migrate-fs-bundlerfrom
markduckworth/bundle-builder-ideas
Mar 20, 2025
Merged

Converting bundle protos to Proto3 JSON compatible format#8855
DellaBitta merged 1 commit intoddb-migrate-fs-bundlerfrom
markduckworth/bundle-builder-ideas

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Mar 20, 2025

Discussion

@MarkDuckworth took a pass at the serialization of bundled objects into a byte buffer using his Firestore innerworking knowhow.

Testing

N/A

API Changes

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 9b3e2f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v7.0

@DellaBitta DellaBitta marked this pull request as ready for review March 20, 2025 17:32
@DellaBitta DellaBitta requested review from a team as code owners March 20, 2025 17:32
@DellaBitta DellaBitta merged commit 3d45407 into ddb-migrate-fs-bundler Mar 20, 2025
18 of 21 checks passed
@DellaBitta DellaBitta deleted the markduckworth/bundle-builder-ideas branch March 20, 2025 17:32
@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Mar 20, 2025

Size Report 1

Affected Products

No changes between base commit (5dd5ae4) and merge commit (8714349).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RfamYiKhZd.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Mar 20, 2025

Size Analysis Report 1

Affected Products

No changes between base commit (5dd5ae4) and merge commit (8714349).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TcfJjfmxju.html

@firebase firebase locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DellaBitta @google-oss-bot @MarkDuckworth