Use Node's TextEncoder in E2E JSDOM Environment#8783
Merged
Conversation
|
Contributor
Vertex AI Mock Responses Check
|
hsubox76
approved these changes
Feb 10, 2025
DellaBitta
approved these changes
Feb 10, 2025
Collaborator
Size Report 1Affected ProductsNo changes between base commit (4e6a5c6) and merge commit (9e1ac2c).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (4e6a5c6) and merge commit (9e1ac2c).Test Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSDOM does not provide a
TextEncoderAPI, which causes the E2E Firestore tests to fail. To fix this, we can use Node'sTextEncoderAPI.Tested against the latest release 11.3.0, and confirmed that the e2e tests are now passing.