Revert the UTF-8 encoding in string sorting#8782
Merged
Conversation
🦋 Changeset detectedLatest commit: 1d42607 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Vertex AI Mock Responses Check
|
Contributor
|
drive-by comment: don't forget a changeset entry |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (481,346 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
dconeybe
reviewed
Feb 10, 2025
.changeset/slimy-chicken-mix.md
Outdated
| 'firebase': patch | ||
| --- | ||
|
|
||
| Reverted a change to use UTF-8 encoding in string comparisons which caused a performance issue. |
Contributor
There was a problem hiding this comment.
Another drive-by comment: Append Fixes #NNNN to allow interested parties to click through to the github issue and understand more context.
dlarocque
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix on string sorting is creating performance issue. Reverting the change back before a patch is added.