Emulator Idempotency: Firestore by DellaBitta · Pull Request #8780 · firebase/firebase-js-sdk

DellaBitta · 2025-02-09T23:58:02Z

Discussion

Update connectFirestoreEmulator to support its invocation more than once. If the Firestore instance is already in use, and connectFirestoreEmulator is invoked with the same configuration, then the invocation will now succeed instead of assert.

The implementation takes the Data Connect implementation as inspiration. Data Connect stores the parameters passed to connectDataConnectEmulator on the instance of Data Connect itself, so that they can be quickly checked to see if subsequent invocations match. This PR implements a similar storage and compare process with the optional emulatorOptions parameter (host and port are already stored).

This PR unlocks support for SSR frameworks which render the page numerous times with the same instances of Firestore. Before this PR customers were required to guard against calling connectFirestoreEmulator in their SSR logic, which added to code complexity. Now the Firebase SDK does that guarding logic so that our users' apps don't have to.

Testing

CI, new tests added to packages/firestore/test/integration/api/validation.test.ts and packages/firestore/test/unit/api/database.test.ts.

API Changes

N/A

github-actions · 2025-02-09T23:58:16Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

changeset-bot · 2025-02-10T00:54:31Z

⚠️ No Changeset found

Latest commit: de0b1e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2025-02-10T01:04:03Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (4e6a5c6) Merge (243afc0) Diff
browser 381 kB 381 kB +246 B (+0.1%)
main 589 kB 590 kB +342 B (+0.1%)
module 381 kB 381 kB +246 B (+0.1%)
react-native 381 kB 381 kB +246 B (+0.1%)
@firebase/firestore-lite
Type Base (4e6a5c6) Merge (243afc0) Diff
browser 112 kB 112 kB +246 B (+0.2%)
main 154 kB 155 kB +342 B (+0.2%)
module 112 kB 112 kB +246 B (+0.2%)
react-native 112 kB 113 kB +246 B (+0.2%)

`bundle`

15 size changes

Type	Base (`4e6a5c6`)	Merge (243afc0)	Diff
firestore (CSI Auto Indexing Disable and Delete)	271 kB	272 kB	+238 B (+0.1%)
firestore (CSI Auto Indexing Enable)	271 kB	272 kB	+238 B (+0.1%)
firestore (Persistence)	303 kB	303 kB	+238 B (+0.1%)
firestore (Query Cursors)	250 kB	250 kB	+238 B (+0.1%)
firestore (Query)	247 kB	247 kB	+238 B (+0.1%)
firestore (Read data once)	235 kB	235 kB	+238 B (+0.1%)
firestore (Read Write w Persistence)	327 kB	327 kB	+238 B (+0.1%)
firestore (Realtime updates)	237 kB	238 kB	+238 B (+0.1%)
firestore (Transaction)	214 kB	215 kB	+238 B (+0.1%)
firestore (Write data)	214 kB	214 kB	+238 B (+0.1%)
firestore-lite (Query Cursors)	103 kB	103 kB	+238 B (+0.2%)
firestore-lite (Query)	99.4 kB	99.6 kB	+238 B (+0.2%)
firestore-lite (Read data once)	74.8 kB	75.1 kB	+238 B (+0.3%)
firestore-lite (Transaction)	100 kB	100 kB	+238 B (+0.2%)
firestore-lite (Write data)	84.4 kB	84.7 kB	+238 B (+0.3%)

`firebase`

Type	Base (`4e6a5c6`)	Merge (243afc0)	Diff
firebase-compat.js	791 kB	792 kB	+237 B (+0.0%)
firebase-firestore-compat.js	339 kB	339 kB	+236 B (+0.1%)
firebase-firestore-lite.js	131 kB	131 kB	+246 B (+0.2%)
firebase-firestore.js	439 kB	439 kB	+246 B (+0.1%)

Test Logs

Base (4e6a5c6): https://github.com/firebase/firebase-js-sdk/actions/runs/13187328462
Merge (243afc0): https://github.com/firebase/firebase-js-sdk/actions/runs/13245307113

https://storage.googleapis.com/firebase-sdk-metric-reports/nu1jMhSLQ2.html

google-oss-bot · 2025-02-10T01:15:50Z

Size Analysis Report ¹

Affected Products

`@firebase/firestore`

AbstractUserDataWriter
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 24.8 kB 24.9 kB +120 B (+0.5%)
size-with-ext-deps 94.9 kB 95.0 kB +120 B (+0.1%)
AggregateField
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.6 kB +120 B (+0.1%)
AggregateQuerySnapshot
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.5 kB 15.6 kB +120 B (+0.8%)
size-with-ext-deps 85.6 kB 85.7 kB +120 B (+0.1%)
Bytes
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.9 kB 17.0 kB +120 B (+0.7%)
size-with-ext-deps 86.9 kB 87.1 kB +120 B (+0.1%)
CACHE_SIZE_UNLIMITED
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
CollectionReference
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.5 kB 19.7 kB +120 B (+0.6%)
size-with-ext-deps 89.7 kB 89.8 kB +120 B (+0.1%)
DocumentReference
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.5 kB 19.7 kB +120 B (+0.6%)
size-with-ext-deps 89.7 kB 89.8 kB +120 B (+0.1%)
DocumentSnapshot
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 23.0 kB 23.2 kB +120 B (+0.5%)
size-with-ext-deps 93.2 kB 93.3 kB +120 B (+0.1%)
FieldPath
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 18.5 kB 18.7 kB +120 B (+0.6%)
size-with-ext-deps 88.7 kB 88.8 kB +120 B (+0.1%)
FieldValue
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.6 kB +120 B (+0.1%)
Firestore
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.4 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
FirestoreError
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.4 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
GeoPoint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.9 kB 16.0 kB +120 B (+0.8%)
size-with-ext-deps 86.0 kB 86.1 kB +120 B (+0.1%)
LoadBundleTask
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.2 kB 16.3 kB +120 B (+0.7%)
size-with-ext-deps 86.3 kB 86.4 kB +120 B (+0.1%)
PersistentCacheIndexManager
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.6 kB +120 B (+0.1%)
Query
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.5 kB 15.6 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.7 kB +120 B (+0.1%)
QueryCompositeFilterConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 17.6 kB 17.7 kB +120 B (+0.7%)
size-with-ext-deps 87.7 kB 87.8 kB +120 B (+0.1%)
QueryConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
QueryDocumentSnapshot
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 23.0 kB 23.2 kB +120 B (+0.5%)
size-with-ext-deps 93.2 kB 93.3 kB +120 B (+0.1%)
QueryEndAtConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.3 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
QueryFieldFilterConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 40.7 kB 40.8 kB +120 B (+0.3%)
size-with-ext-deps 111 kB 111 kB +120 B (+0.1%)
QueryLimitConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.1 kB 16.2 kB +120 B (+0.7%)
size-with-ext-deps 86.2 kB 86.3 kB +120 B (+0.1%)
QueryOrderByConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.5 kB 16.7 kB +120 B (+0.7%)
size-with-ext-deps 86.6 kB 86.8 kB +120 B (+0.1%)
QuerySnapshot
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 25.0 kB 25.1 kB +120 B (+0.5%)
size-with-ext-deps 95.1 kB 95.2 kB +120 B (+0.1%)
QueryStartAtConstraint
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.3 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
SnapshotMetadata
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.5 kB 15.6 kB +120 B (+0.8%)
size-with-ext-deps 85.6 kB 85.7 kB +120 B (+0.1%)
Timestamp
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.5 kB 16.6 kB +120 B (+0.7%)
size-with-ext-deps 86.6 kB 86.7 kB +120 B (+0.1%)
Transaction
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 50.8 kB 51.0 kB +120 B (+0.2%)
size-with-ext-deps 121 kB 121 kB +120 B (+0.1%)
VectorValue
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.6 kB 15.7 kB +120 B (+0.8%)
size-with-ext-deps 85.6 kB 85.8 kB +120 B (+0.1%)
WriteBatch
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 47.3 kB 47.5 kB +120 B (+0.3%)
size-with-ext-deps 118 kB 118 kB +120 B (+0.1%)
_AutoId
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.8 kB 15.9 kB +120 B (+0.8%)
size-with-ext-deps 85.9 kB 86.0 kB +120 B (+0.1%)
_ByteString
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.4 kB 16.5 kB +120 B (+0.7%)
size-with-ext-deps 86.5 kB 86.6 kB +120 B (+0.1%)
_DatabaseId
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.4 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
_DocumentKey
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 25.2 kB 25.3 kB +120 B (+0.5%)
size-with-ext-deps 95.3 kB 95.4 kB +120 B (+0.1%)
_EmptyAppCheckTokenProvider
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.6 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.6 kB +120 B (+0.1%)
_EmptyAuthCredentialsProvider
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
_FieldPath
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 18.3 kB 18.4 kB +120 B (+0.7%)
size-with-ext-deps 88.4 kB 88.5 kB +120 B (+0.1%)
_TestingHooks
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.8 kB 15.9 kB +120 B (+0.8%)
size-with-ext-deps 85.9 kB 86.0 kB +120 B (+0.1%)
_cast
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.1 kB 16.2 kB +120 B (+0.7%)
size-with-ext-deps 86.2 kB 86.3 kB +120 B (+0.1%)
_debugAssert
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
_internalAggregationQueryToProtoRunAggregationQueryRequest
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 36.8 kB 36.9 kB +120 B (+0.3%)
size-with-ext-deps 107 kB 107 kB +120 B (+0.1%)
_internalQueryToProtoQueryTarget
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 44.5 kB 44.6 kB +120 B (+0.3%)
size-with-ext-deps 115 kB 115 kB +120 B (+0.1%)
_isBase64Available
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.6 kB +120 B (+0.1%)
_logWarn
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.6 kB +120 B (+0.1%)
_validateIsNotUsedTogether
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
addDoc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 133 kB 133 kB +120 B (+0.1%)
size-with-ext-deps 205 kB 205 kB +120 B (+0.1%)
aggregateFieldEqual
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.7 kB 15.8 kB +120 B (+0.8%)
size-with-ext-deps 85.8 kB 85.9 kB +120 B (+0.1%)
aggregateQuerySnapshotEqual
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 39.5 kB 39.6 kB +120 B (+0.3%)
size-with-ext-deps 110 kB 110 kB +120 B (+0.1%)
and
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.0 kB 42.1 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 112 kB +120 B (+0.1%)
arrayRemove
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 29.4 kB 29.5 kB +120 B (+0.4%)
size-with-ext-deps 99.8 kB 100 kB +120 B (+0.1%)
arrayUnion
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 29.4 kB 29.5 kB +120 B (+0.4%)
size-with-ext-deps 99.8 kB 100 kB +120 B (+0.1%)
average
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.6 kB 19.7 kB +120 B (+0.6%)
size-with-ext-deps 89.7 kB 89.8 kB +120 B (+0.1%)
clearIndexedDbPersistence
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 24.1 kB 24.2 kB +120 B (+0.5%)
size-with-ext-deps 94.3 kB 94.4 kB +120 B (+0.1%)
collection
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 20.3 kB 20.4 kB +120 B (+0.6%)
size-with-ext-deps 90.4 kB 90.5 kB +120 B (+0.1%)
collectionGroup
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.3 kB 19.4 kB +120 B (+0.6%)
size-with-ext-deps 89.4 kB 89.5 kB +120 B (+0.1%)
connectFirestoreEmulator
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 17.1 kB 17.4 kB +255 B (+1.5%)
size-with-ext-deps 87.8 kB 88.4 kB +586 B (+0.7%)
External Dependency
Module Base (4e6a5c6) Merge (243afc0) Diff
@firebase/util
FirebaseError createMockUserToken
FirebaseError createMockUserToken deepEqual
+ deepEqual
count
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.5 kB 15.6 kB +120 B (+0.8%)
size-with-ext-deps 85.5 kB 85.7 kB +120 B (+0.1%)
deleteAllPersistentCacheIndexes
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 95.9 kB 96.0 kB +120 B (+0.1%)
size-with-ext-deps 168 kB 168 kB +120 B (+0.1%)
deleteDoc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 123 kB 123 kB +120 B (+0.1%)
size-with-ext-deps 195 kB 195 kB +120 B (+0.1%)
deleteField
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.7 kB 15.8 kB +120 B (+0.8%)
size-with-ext-deps 85.8 kB 85.9 kB +120 B (+0.1%)
disableNetwork
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 112 kB 112 kB +120 B (+0.1%)
size-with-ext-deps 183 kB 184 kB +120 B (+0.1%)
disablePersistentCacheIndexAutoCreation
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 95.9 kB 96.0 kB +120 B (+0.1%)
size-with-ext-deps 167 kB 168 kB +120 B (+0.1%)
doc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 20.8 kB 20.9 kB +120 B (+0.6%)
size-with-ext-deps 91.0 kB 91.1 kB +120 B (+0.1%)
documentId
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 18.6 kB 18.7 kB +120 B (+0.6%)
size-with-ext-deps 88.7 kB 88.8 kB +120 B (+0.1%)
enableIndexedDbPersistence
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 186 kB 186 kB +120 B (+0.1%)
size-with-ext-deps 258 kB 258 kB +120 B (+0.0%)
enableMultiTabIndexedDbPersistence
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 222 kB 222 kB +120 B (+0.1%)
size-with-ext-deps 294 kB 294 kB +120 B (+0.0%)
enableNetwork
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 112 kB 112 kB +120 B (+0.1%)
size-with-ext-deps 183 kB 184 kB +120 B (+0.1%)
enablePersistentCacheIndexAutoCreation
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 95.9 kB 96.0 kB +120 B (+0.1%)
size-with-ext-deps 167 kB 168 kB +120 B (+0.1%)
endAt
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.4 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
endBefore
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.4 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
ensureFirestoreConfigured
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 18.5 kB 18.7 kB +120 B (+0.6%)
size-with-ext-deps 88.6 kB 88.8 kB +120 B (+0.1%)
executeWrite
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 122 kB 122 kB +120 B (+0.1%)
size-with-ext-deps 194 kB 194 kB +120 B (+0.1%)
getAggregateFromServer
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 119 kB 119 kB +120 B (+0.1%)
size-with-ext-deps 191 kB 191 kB +120 B (+0.1%)
getCountFromServer
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 119 kB 120 kB +120 B (+0.1%)
size-with-ext-deps 191 kB 191 kB +120 B (+0.1%)
getDoc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 154 kB 154 kB +120 B (+0.1%)
size-with-ext-deps 226 kB 226 kB +120 B (+0.1%)
getDocFromCache
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 104 kB 104 kB +120 B (+0.1%)
size-with-ext-deps 175 kB 176 kB +120 B (+0.1%)
getDocFromServer
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 154 kB 154 kB +120 B (+0.1%)
size-with-ext-deps 226 kB 226 kB +120 B (+0.1%)
getDocs
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 155 kB 155 kB +120 B (+0.1%)
size-with-ext-deps 227 kB 227 kB +120 B (+0.1%)
getDocsFromCache
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 111 kB 112 kB +120 B (+0.1%)
size-with-ext-deps 183 kB 183 kB +120 B (+0.1%)
getDocsFromServer
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 155 kB 155 kB +120 B (+0.1%)
size-with-ext-deps 227 kB 227 kB +120 B (+0.1%)

`getFirestore`

Size

Type	Base (`4e6a5c6`)	Merge (243afc0)	Diff
size	17.4 kB	17.6 kB	+256 B (+1.5%)
size-with-ext-deps	95.7 kB	95.9 kB	+238 B (+0.2%)

External Dependency

Module	Base (`4e6a5c6`)	Merge (243afc0)	Diff
`@firebase/util`	FirebaseError createMockUserToken getDefaultEmulatorHostnameAndPort	FirebaseError createMockUserToken deepEqual getDefaultEmulatorHostnameAndPort	+ deepEqual

getPersistentCacheIndexManager
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.7 kB 19.8 kB +120 B (+0.6%)
size-with-ext-deps 89.8 kB 89.9 kB +120 B (+0.1%)
increment
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.2 kB 16.3 kB +120 B (+0.7%)
size-with-ext-deps 86.3 kB 86.4 kB +120 B (+0.1%)
initializeFirestore
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.2 kB 16.3 kB +120 B (+0.7%)
size-with-ext-deps 86.8 kB 86.9 kB +120 B (+0.1%)
limit
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.3 kB 16.4 kB +120 B (+0.7%)
size-with-ext-deps 86.4 kB 86.5 kB +120 B (+0.1%)
limitToLast
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 16.3 kB 16.4 kB +120 B (+0.7%)
size-with-ext-deps 86.4 kB 86.5 kB +120 B (+0.1%)
loadBundle
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 121 kB 121 kB +120 B (+0.1%)
size-with-ext-deps 193 kB 193 kB +120 B (+0.1%)
memoryEagerGarbageCollector
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 84.3 kB 84.4 kB +120 B (+0.1%)
size-with-ext-deps 156 kB 156 kB +120 B (+0.1%)
memoryLocalCache
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 106 kB 106 kB +120 B (+0.1%)
size-with-ext-deps 178 kB 178 kB +120 B (+0.1%)
memoryLruGarbageCollector
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 90.8 kB 90.9 kB +120 B (+0.1%)
size-with-ext-deps 162 kB 163 kB +120 B (+0.1%)
namedQuery
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 96.7 kB 96.9 kB +120 B (+0.1%)
size-with-ext-deps 168 kB 168 kB +120 B (+0.1%)
onSnapshot
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 156 kB 156 kB +120 B (+0.1%)
size-with-ext-deps 228 kB 228 kB +120 B (+0.1%)
onSnapshotsInSync
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 145 kB 145 kB +120 B (+0.1%)
size-with-ext-deps 217 kB 217 kB +120 B (+0.1%)
or
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.0 kB 42.1 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 112 kB +120 B (+0.1%)
orderBy
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 20.6 kB 20.7 kB +120 B (+0.6%)
size-with-ext-deps 90.7 kB 90.8 kB +120 B (+0.1%)
persistentLocalCache
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 182 kB 182 kB +120 B (+0.1%)
size-with-ext-deps 254 kB 254 kB +120 B (+0.0%)
persistentMultipleTabManager
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 218 kB 218 kB +120 B (+0.1%)
size-with-ext-deps 290 kB 290 kB +120 B (+0.0%)
persistentSingleTabManager
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 182 kB 182 kB +120 B (+0.1%)
size-with-ext-deps 254 kB 254 kB +120 B (+0.0%)
query
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.3 kB 42.4 kB +120 B (+0.3%)
size-with-ext-deps 113 kB 113 kB +120 B (+0.1%)
queryEqual
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 39.3 kB 39.5 kB +120 B (+0.3%)
size-with-ext-deps 110 kB 110 kB +120 B (+0.1%)
refEqual
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.7 kB 19.9 kB +120 B (+0.6%)
size-with-ext-deps 89.9 kB 90.0 kB +120 B (+0.1%)
runTransaction
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 133 kB 133 kB +120 B (+0.1%)
size-with-ext-deps 205 kB 205 kB +120 B (+0.1%)
serverTimestamp
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.6 kB 15.7 kB +120 B (+0.8%)
size-with-ext-deps 85.7 kB 85.8 kB +120 B (+0.1%)
setDoc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 132 kB 132 kB +120 B (+0.1%)
size-with-ext-deps 204 kB 204 kB +120 B (+0.1%)
setIndexConfiguration
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 99.3 kB 99.4 kB +120 B (+0.1%)
size-with-ext-deps 171 kB 171 kB +120 B (+0.1%)
setLogLevel
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.3 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.4 kB 85.5 kB +120 B (+0.1%)
snapshotEqual
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 45.0 kB 45.2 kB +120 B (+0.3%)
size-with-ext-deps 115 kB 115 kB +120 B (+0.1%)
startAfter
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.4 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
startAt
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 42.2 kB 42.4 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 113 kB +120 B (+0.1%)
sum
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 19.5 kB 19.7 kB +120 B (+0.6%)
size-with-ext-deps 89.7 kB 89.8 kB +120 B (+0.1%)
terminate
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.4 kB 15.5 kB +120 B (+0.8%)
size-with-ext-deps 85.7 kB 85.8 kB +120 B (+0.1%)
updateDoc
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 132 kB 132 kB +120 B (+0.1%)
size-with-ext-deps 204 kB 204 kB +120 B (+0.1%)
vector
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 15.6 kB 15.7 kB +120 B (+0.8%)
size-with-ext-deps 85.7 kB 85.8 kB +120 B (+0.1%)
waitForPendingWrites
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 112 kB 112 kB +120 B (+0.1%)
size-with-ext-deps 184 kB 184 kB +120 B (+0.1%)
where
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 41.5 kB 41.6 kB +120 B (+0.3%)
size-with-ext-deps 112 kB 112 kB +120 B (+0.1%)
writeBatch
Size
Type Base (4e6a5c6) Merge (243afc0) Diff
size 134 kB 134 kB +120 B (+0.1%)
size-with-ext-deps 206 kB 206 kB +120 B (+0.1%)

Test Logs

Base (4e6a5c6): https://github.com/firebase/firebase-js-sdk/actions/runs/13187328462
Merge (243afc0): https://github.com/firebase/firebase-js-sdk/actions/runs/13245307113

https://storage.googleapis.com/firebase-sdk-metric-reports/rQfuvTK1Mw.html

dlarocque · 2025-02-11T20:41:18Z

common/api-review/firestore-lite.api.md

 // @public
 export function writeBatch(firestore: Firestore): WriteBatch;

+


i did not see this API proposal 😮

It was a blank document. :)

MarkDuckworth

LGTM. However, the description says this fixes #6824, but that is related to Auth. Not a big deal because you're apply this to auth at the same time, but in a different PR.

DellaBitta · 2025-02-11T21:47:21Z

LGTM. However, the description says this fixes #6824, but that is related to Auth. Not a big deal because you're apply this to auth at the same time, but in a different PR.

Righto, removed that Fixes comment in the PR. Thanks for the review!

DellaBitta added 3 commits February 7, 2025 15:41

Implementation

02ca42e

getPrivateSettings

7dce485

internal getSettings returns PrivateSettings

464c68e

getPrivateSettings and tests

8d0a11d

DellaBitta changed the title ~~Ddb firestore emulator reconnect~~ Emulator Idempotency: Firestore Feb 10, 2025

DellaBitta added 4 commits February 9, 2025 20:18

Guard validation tests with USE_EMULATOR

4a49493

Dynamic port for tests.

d9168d5

Remove _getPrivateSettings

de0b1e3

Remove debug output, fix emulatorOptions typo.

f0c797c

This was referenced Feb 10, 2025

Emulator Idempotency: Auth #8750

Merged

Emulator Idempotency: Database #8769

Merged

DellaBitta marked this pull request as ready for review February 10, 2025 19:48

DellaBitta requested review from a team as code owners February 10, 2025 19:48

dlarocque approved these changes Feb 11, 2025

View reviewed changes

MarkDuckworth approved these changes Feb 11, 2025

View reviewed changes

DellaBitta merged commit 69c3326 into main Feb 11, 2025
49 checks passed

DellaBitta deleted the ddb-firestore-emulator-reconnect branch February 11, 2025 21:47

firebase locked and limited conversation to collaborators Mar 14, 2025

		// @public
		export function writeBatch(firestore: Firestore): WriteBatch;

Conversation

DellaBitta commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Discussion

Testing

API Changes

Uh oh!

github-actions bot commented Feb 9, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

changeset-bot bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

AggregateField

AggregateQuerySnapshot

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

PersistentCacheIndexManager

Query

QueryCompositeFilterConstraint

QueryConstraint

QueryDocumentSnapshot

QueryEndAtConstraint

QueryFieldFilterConstraint

QueryLimitConstraint

QueryOrderByConstraint

QuerySnapshot

QueryStartAtConstraint

SnapshotMetadata

Timestamp

Transaction

VectorValue

WriteBatch

_AutoId

_ByteString

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_TestingHooks

_cast

_debugAssert

_internalAggregationQueryToProtoRunAggregationQueryRequest

_internalQueryToProtoQueryTarget

_isBase64Available

_logWarn

_validateIsNotUsedTogether

addDoc

aggregateFieldEqual

aggregateQuerySnapshotEqual

and

arrayRemove

arrayUnion

DellaBitta commented Feb 9, 2025 •

edited

Loading

changeset-bot bot commented Feb 10, 2025 •

edited

Loading

google-oss-bot commented Feb 10, 2025 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Feb 10, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`AggregateField`

`AggregateQuerySnapshot`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`PersistentCacheIndexManager`

`Query`

`QueryCompositeFilterConstraint`

`QueryConstraint`

`QueryDocumentSnapshot`

`QueryEndAtConstraint`

`QueryFieldFilterConstraint`

`QueryLimitConstraint`

`QueryOrderByConstraint`

`QuerySnapshot`

`QueryStartAtConstraint`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`VectorValue`

`WriteBatch`

`_AutoId`

`_ByteString`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_TestingHooks`

`_cast`

`_debugAssert`

`_internalAggregationQueryToProtoRunAggregationQueryRequest`

`_internalQueryToProtoQueryTarget`

`_isBase64Available`

`_logWarn`

`_validateIsNotUsedTogether`

`addDoc`

`aggregateFieldEqual`

`aggregateQuerySnapshotEqual`

`and`

`arrayRemove`

`arrayUnion`

`average`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`count`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`deleteField`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`endAt`