Data Connect: Add support for web framework tracking via custom headers#8749
Merged
Data Connect: Add support for web framework tracking via custom headers#8749
Conversation
🦋 Changeset detectedLatest commit: 99cced0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Vertex AI Mock Responses Check
|
maneesht
reviewed
Jan 31, 2025
maneesht
reviewed
Jan 31, 2025
maneesht
reviewed
Jan 31, 2025
maneesht
reviewed
Jan 31, 2025
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (70,082 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
maneesht
reviewed
Feb 3, 2025
DellaBitta
reviewed
Feb 3, 2025
Contributor
DellaBitta
left a comment
There was a problem hiding this comment.
Could you add a Changset please?
maneesht
reviewed
Feb 3, 2025
Contributor
Changeset File Check ✅
|
DellaBitta
reviewed
Feb 4, 2025
.changeset/little-news-sniff.md
Outdated
| 'firebase': minor | ||
| --- | ||
|
|
||
| Add custom request headers based on type of SDK calling Core SDK |
Contributor
There was a problem hiding this comment.
This will become release notes shortly. Could you rephrase this with our users in mind. Maybe something like:
Changed: Add custom request headers based on the type of SDK (TanStack, Angular, etc) that's invoking Data Connect requests. This will help us something something.
Contributor
Author
There was a problem hiding this comment.
Done - let me know what you think
hsubox76
approved these changes
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
reviewed
Feb 4, 2025
maneesht
approved these changes
Feb 4, 2025
aashishpatil-g
approved these changes
Feb 5, 2025
DellaBitta
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for web framework tracking via custom headers
CallerSdkTypeEnumenum to differentiate between frameworks_callerSdkTypefield and_setCallerSdkType()methods toDataConnecttype, as well asDataConnectTransporttypes_isUsingGenfields and functions (_isUsingGen = falseis now represented byCallerSdkTypeEnum.Base, while_isUsingGen = trueis represented by any value other thanCallerSdkTypeEnum.Base)