Skip to content

Convert enum comments to JSDoc comments#8742

Merged
dlarocque merged 5 commits intomainfrom
dl/enum-devsite
Mar 5, 2025
Merged

Convert enum comments to JSDoc comments#8742
dlarocque merged 5 commits intomainfrom
dl/enum-devsite

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 30, 2025

Convert enum value comments to use the /** comment syntax to be recognized by the JSDoc parser, so that they can be added to devsite.

@dlarocque dlarocque requested review from a team as code owners January 30, 2025 16:29
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e1a334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jan 30, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (058afa2) and merge commit (250af1b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ICYAu6C5E6.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jan 30, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (058afa2) and merge commit (250af1b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/A8F2k6Dcz3.html

rachelsaunders
rachelsaunders requested changes Jan 30, 2025
View reviewed changes
hsubox76
hsubox76 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dlarocque dlarocque merged commit 42cea48 into main Mar 5, 2025
37 checks passed
@dlarocque dlarocque deleted the dl/enum-devsite branch March 5, 2025 15:57
@firebase firebase locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlarocque @google-oss-bot @hsubox76 @rachelsaunders