Skip to content

Upgrade two more download-artifact v3 actions to v4 in Firestore workflow#8706

Merged
DellaBitta merged 2 commits intomainfrom
ddb-fix-firestore-workflow
Jan 14, 2025
Merged

Upgrade two more download-artifact v3 actions to v4 in Firestore workflow#8706
DellaBitta merged 2 commits intomainfrom
ddb-fix-firestore-workflow

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jan 14, 2025

Discussion

There were a pair of download-artifact GitHub actions that were still set to v3 instead of v4. The v3 actions were unable to find the build archive in the test-changed-firestore workflow. This PR upgrades those to v4 actions.

For an example of this failure, check this CI run.

Testing

CI.

API Changes

N/A.

@DellaBitta DellaBitta requested a review from a team as a code owner January 14, 2025 20:28
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5344133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jan 14, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0755a72) and merge commit (e063ac4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lGgS0k9BB8.html

@DellaBitta DellaBitta changed the title Upgraded two download-artifact v3 actions in Firestore workflow Upgrade two more download-artifact v3 actions to v4 in Firestore workflow Jan 14, 2025
@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jan 14, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (0755a72) and merge commit (e063ac4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c2r2iSD4j2.html

hsubox76
hsubox76 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it wasn't caught by the Renovate PR #8128 because that PR was originally created in April and last updated in May, and Daniel added these jobs in October?

@DellaBitta DellaBitta merged commit 0b318a9 into main Jan 14, 2025
50 checks passed
@DellaBitta DellaBitta deleted the ddb-fix-firestore-workflow branch January 14, 2025 23:47
@firebase firebase locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DellaBitta @google-oss-bot @hsubox76