SSR related improvements for RC client SDK.#8699
Merged
DellaBitta merged 19 commits intomainfrom Feb 11, 2025
Merged
Conversation
added 8 commits
January 8, 2025 15:26
🦋 Changeset detectedLatest commit: bb99031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (779,027 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Contributor
Changeset File Check ✅
|
DellaBitta
reviewed
Jan 13, 2025
DellaBitta
requested changes
Jan 15, 2025
jenh
requested changes
Jan 21, 2025
jenh
left a comment
There was a problem hiding this comment.
A few interface links are dropping out of the devsite docs, but otherwise LGTM.
jenh
requested changes
Jan 21, 2025
jenh
left a comment
There was a problem hiding this comment.
(Missed a few things, thanks to @egilmorez for the assist!)
jenh
approved these changes
Jan 22, 2025
DellaBitta
requested changes
Jan 23, 2025
Contributor
DellaBitta
left a comment
There was a problem hiding this comment.
One more change from my end, then waiting on @jamesdaniels' testing for final merge approval.
added 2 commits
January 27, 2025 11:13
Member
|
Ok, in my testing things are working alright. I did have to construct the RemoteConfigFetchResponse myself though, did we intend to include the class in this PR? Right now it's only exported as an interface and it wasn't clear how to construct config from the public api. Here's my Angular SSR component, let me know if I misunderstood anything. import { Component, inject, makeStateKey, PendingTasks, PLATFORM_ID, TransferState } from '@angular/core';
import { getAllChanges } from '@angular/fire/remote-config';
import { traceUntilFirst } from '@angular/fire/performance';
import { from, Observable, switchMap } from 'rxjs';
import { AsyncPipe, isPlatformServer, JsonPipe } from '@angular/common';
import { FirebaseApp } from '@angular/fire/app';
import { getRemoteConfig as getAdminRemoteConfig } from "firebase-admin/remote-config";
import { FirebaseAdminApp } from '../app.config';
import { getRemoteConfig, RemoteConfig, FetchResponse } from "@firebase/remote-config";
import { AllParameters } from 'rxfire/remote-config';
@Component({
selector: 'app-remote-config',
template: `<p>Remote Config! <code>{{ config$ | async | json }}</code></p>`,
imports: [AsyncPipe, JsonPipe],
})
export class RemoteConfigComponent {
private readonly transferState = inject(TransferState);
private readonly transferStateKey = makeStateKey<FetchResponse>("remote-config-server-config");
private readonly resolveRemoteConfig: Promise<RemoteConfig>;
protected readonly config$: Observable<AllParameters>;
constructor() {
const firebaseApp = inject(FirebaseApp);
if (isPlatformServer(inject(PLATFORM_ID))) {
const serverApp = inject(FirebaseAdminApp);
const adminRemoteConfig = getAdminRemoteConfig(serverApp);
const pendingTasks = inject(PendingTasks);
this.resolveRemoteConfig = pendingTasks.run(() =>
adminRemoteConfig.getServerTemplate().then(template => {
const serverConfig = template.evaluate();
// Expect this to work
// const initialFetchResponse = new RemoteConfigFetchResponse(serverApp, serverConfig);
const initialFetchResponse = {
status: 200,
eTag: "asuidfhiouasf",
config: { yada: "baz" }, // TODO don't hardcode, need to pull these values from the serverConfig
};
this.transferState.set(this.transferStateKey, initialFetchResponse);
return getRemoteConfig(firebaseApp, {
initialFetchResponse,
});
})
);
} else {
const initialFetchResponse = this.transferState.get(this.transferStateKey, undefined);
this.resolveRemoteConfig = Promise.resolve(getRemoteConfig(firebaseApp, {
initialFetchResponse,
}));
}
this.config$ = from(this.resolveRemoteConfig).pipe(
switchMap(remoteConfig => getAllChanges(remoteConfig)),
traceUntilFirst('remote-config'),
);
}
} |
Member
|
Ok, it seems that API is in the works over here firebase/firebase-admin-node#2829 |
jamesdaniels
approved these changes
Feb 7, 2025
Member
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM. Nit we should update isSupported to return true on the server
DellaBitta
approved these changes
Feb 11, 2025
This was referenced Feb 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSR related improvements for RC client SDK.