Clear fetch abort timeout by dlarocque · Pull Request #8663 · firebase/firebase-js-sdk

dlarocque · 2024-12-03T19:08:35Z

We set a timeout to abort a request after 180s by default, but we don't cancel this timeout after the request completes. We should cancel this timeout after the request completes to prevent Node scripts from hanging.

I inlined everything in buildFetchOptions and removed that function. Let me know if I should revert this and initialize the AbortController in there- but I think the timeout-related code still has to be inlined so that we can get the timeoutId.

I tested this in a Node script using the default timeout and a custom timeout, and they both work as expected. If the timeout is triggered before the request completes, an AbortError is thrown. If the request completes before the timeout is triggered, the timeout is cancelled, and the Node script is able to exit.

Fixes b/380936830 (internal)

changeset-bot · 2024-12-03T19:08:39Z

🦋 Changeset detected

Latest commit: 02b9fc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@firebase/vertexai	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2024-12-03T19:20:55Z

Size Report ¹

Affected Products

@firebase/messaging
Type Base (ffbf5a6) Merge (780b37f) Diff
browser 21.3 kB 22.0 kB +765 B (+3.6%)
main 21.7 kB 22.4 kB +765 B (+3.5%)
module 21.3 kB 22.0 kB +765 B (+3.6%)
@firebase/vertexai
Type Base (ffbf5a6) Merge (780b37f) Diff
browser 28.9 kB 28.8 kB -83 B (-0.3%)
main 29.7 kB 29.6 kB -83 B (-0.3%)
module 28.9 kB 28.8 kB -83 B (-0.3%)
bundle
Type Base (ffbf5a6) Merge (780b37f) Diff
messaging (send + receive) 46.9 kB 47.4 kB +466 B (+1.0%)

`firebase`

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
firebase-compat.js	794 kB	795 kB	+408 B (+0.1%)
firebase-messaging-compat.js	38.3 kB	38.7 kB	+408 B (+1.1%)
firebase-messaging.js	28.7 kB	29.1 kB	+452 B (+1.6%)
firebase-vertexai.js	23.9 kB	23.8 kB	-90 B (-0.4%)

Test Logs

Base (ffbf5a6): https://github.com/firebase/firebase-js-sdk/actions/runs/11961696999
Merge (780b37f): https://github.com/firebase/firebase-js-sdk/actions/runs/12165217103

https://storage.googleapis.com/firebase-sdk-metric-reports/jSeFfPhgXn.html

packages/vertexai/src/requests/request.ts

google-oss-bot · 2024-12-03T19:33:10Z

Size Analysis Report ¹

Affected Products

`@firebase/messaging`

`deleteToken`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	12.7 kB	13.1 kB	+465 B (+3.7%)
size-with-ext-deps	39.4 kB	39.9 kB	+466 B (+1.2%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

39 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteToken
deleteToken$1
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

40 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteToken
deleteToken$1
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey
waitForRegistrationActive

+ waitForRegistrationActive

variables

24 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

25 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_REGISTRATION_TIMEOUT
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

+ DEFAULT_REGISTRATION_TIMEOUT

`getMessaging`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	12.7 kB	13.2 kB	+465 B (+3.6%)
size-with-ext-deps	46.6 kB	47.0 kB	+466 B (+1.0%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMessagingInWindow
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

38 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMessagingInWindow
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey
waitForRegistrationActive

+ waitForRegistrationActive

variables

24 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

25 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_REGISTRATION_TIMEOUT
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

+ DEFAULT_REGISTRATION_TIMEOUT

`getToken`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	12.2 kB	12.6 kB	+467 B (+3.8%)
size-with-ext-deps	38.9 kB	39.3 kB	+466 B (+1.2%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

36 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey
waitForRegistrationActive

+ waitForRegistrationActive

variables

24 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

25 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_REGISTRATION_TIMEOUT
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

+ DEFAULT_REGISTRATION_TIMEOUT

`isSupported`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	12.5 kB	13.0 kB	+465 B (+3.7%)
size-with-ext-deps	39.2 kB	39.7 kB	+466 B (+1.2%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

36 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey
waitForRegistrationActive

+ waitForRegistrationActive

variables

24 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

25 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_REGISTRATION_TIMEOUT
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

+ DEFAULT_REGISTRATION_TIMEOUT

`onMessage`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	12.3 kB	12.8 kB	+467 B (+3.8%)
size-with-ext-deps	39.0 kB	39.5 kB	+466 B (+1.2%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
onMessage
onMessage$1
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

38 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
onMessage
onMessage$1
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey
waitForRegistrationActive

+ waitForRegistrationActive

variables

24 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

25 dependencies

CONSOLE_CAMPAIGN_ANALYTICS_ENABLED
CONSOLE_CAMPAIGN_ID
CONSOLE_CAMPAIGN_NAME
CONSOLE_CAMPAIGN_TIME
DATABASE_NAME
DATABASE_VERSION
DEFAULT_REGISTRATION_TIMEOUT
DEFAULT_SW_PATH
DEFAULT_SW_SCOPE
DEFAULT_VAPID_KEY
ENDPOINT
ERROR_FACTORY
ERROR_MAP
MessageType
MessageType$1
OBJECT_STORE_NAME
OLD_DB_NAME
OLD_DB_VERSION
OLD_OBJECT_STORE_NAME
TOKEN_EXPIRATION_MS
WindowMessagingFactory
WindowMessagingInternalFactory
dbPromise
name
version

+ DEFAULT_REGISTRATION_TIMEOUT

`@firebase/vertexai`

`ChatSession`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	14.7 kB	14.6 kB	-48 B (-0.3%)
size-with-ext-deps	33.2 kB	33.1 kB	-48 B (-0.1%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

22 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
createEnhancedContentResponse
formatBlockErrorMessage
formatNewContent
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

21 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
createEnhancedContentResponse
formatBlockErrorMessage
formatNewContent
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

- buildFetchOptions

variables

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

27 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ DEFAULT_FETCH_TIMEOUT_MS

`GenerativeModel`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	17.2 kB	17.1 kB	-48 B (-0.3%)
size-with-ext-deps	35.7 kB	35.6 kB	-48 B (-0.1%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

25 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

24 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

- buildFetchOptions

variables

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

27 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ DEFAULT_FETCH_TIMEOUT_MS

`getGenerativeModel`

Size

Type	Base (`ffbf5a6`)	Merge (780b37f)	Diff
size	17.3 kB	17.3 kB	-48 B (-0.3%)
size-with-ext-deps	35.8 kB	35.8 kB	-48 B (-0.1%)

Dependency

Type Base (ffbf5a6) Merge (780b37f) Diff

functions

26 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

25 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

- buildFetchOptions

variables

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

27 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ DEFAULT_FETCH_TIMEOUT_MS

Test Logs

Base (ffbf5a6): https://github.com/firebase/firebase-js-sdk/actions/runs/11961696999
Merge (780b37f): https://github.com/firebase/firebase-js-sdk/actions/runs/12165217103

https://storage.googleapis.com/firebase-sdk-metric-reports/6N99aXI0Z2.html

DellaBitta

Only suggestion

packages/vertexai/src/requests/request.ts

hsubox76

Approved with one minor nit.

Clear fetch abort timeout

e9ae353

dlarocque requested review from DellaBitta and hsubox76 December 3, 2024 19:08

dlarocque requested review from a team as code owners December 3, 2024 19:08

hsubox76 reviewed Dec 3, 2024

View reviewed changes

packages/vertexai/src/requests/request.ts Outdated Show resolved Hide resolved

packages/vertexai/src/requests/request.ts Outdated Show resolved Hide resolved

packages/vertexai/src/requests/request.ts Show resolved Hide resolved

Add timeout constant and bring back minimum timeout value

f12e7c8

DellaBitta approved these changes Dec 3, 2024

View reviewed changes

dlarocque requested a review from hsubox76 December 4, 2024 15:34

hsubox76 reviewed Dec 4, 2024

View reviewed changes

packages/vertexai/src/requests/request.ts Outdated Show resolved Hide resolved

hsubox76 approved these changes Dec 4, 2024

View reviewed changes

Make timeout condition check if null or undefined

02b9fc3

dlarocque merged commit c540ba9 into main Dec 4, 2024

dlarocque deleted the dl/vertex-timeout branch December 4, 2024 17:38

google-oss-bot mentioned this pull request Dec 10, 2024

Version Packages #8672

Merged

firebase locked and limited conversation to collaborators Jan 4, 2025

Conversation

dlarocque commented Dec 3, 2024

Uh oh!

changeset-bot bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/messaging

@firebase/vertexai

bundle

firebase

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/messaging

deleteToken

getMessaging

getToken

isSupported

onMessage

@firebase/vertexai

ChatSession

GenerativeModel

getGenerativeModel

Test Logs

Uh oh!

DellaBitta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Dec 3, 2024 •

edited

Loading

google-oss-bot commented Dec 3, 2024 •

edited

Loading

Size Report ¹

`@firebase/messaging`

`@firebase/vertexai`

`bundle`

`firebase`

google-oss-bot commented Dec 3, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/messaging`

`deleteToken`

`getMessaging`

`getToken`

`isSupported`

`onMessage`

`@firebase/vertexai`

`ChatSession`

`GenerativeModel`

`getGenerativeModel`