Use logger class and send App Check dummy token in header#8591
Merged
Use logger class and send App Check dummy token in header#8591
Conversation
🦋 Changeset detectedLatest commit: 9e8ef56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
approved these changes
Oct 23, 2024
Contributor
DellaBitta
left a comment
There was a problem hiding this comment.
Looks like you can drop the base64 import.
Collaborator
Size Report 1Affected Products
Test Logs |
Contributor
Author
Thanks, got it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Check's
getToken()should never throw, but in case of an error getting a valid App Check token, it fills in the "token" field with a standard dummy token, and adds an "error" field. The backend needs to receive these dummy tokens in the header so the developer can track failed requests. Right now we just don't send them. This change sends the dummy token, and logs a warning if an error is found.I also realized I forgot to include the standard
loggerAPI in VertexAI so I added it. This is a wrapper aroundconsoleused across all products that adds a product name prefix and also enables the globalsetLogLevel()to apply to any console messages called through this wrapper.