Upgrade to TypeScript 5 by dlarocque · Pull Request #8561 · firebase/firebase-js-sdk

dlarocque · 2024-10-09T17:01:10Z

This PR upgrades the version of TypeScript across our entire repo to 5.5.4 (latest is 5.6.3).

The most notable changes are

Modernizing the Prune DTS script to use the updated TypeScript Compiler API.
Upgrading dependencies that are no longer compatible with newer versions of TS (mostly @types/ packages)
Fixing newly reported TS compiler errors
Updating our code to use the updated built-in types (e.g. from lib.dom.d.ts)

changeset-bot · 2024-10-09T17:01:14Z

⚠️ No Changeset found

Latest commit: d693bfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-10-09T17:16:40Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (fe44715) Merge (f4a8fb3) Diff
browser 381 kB 381 kB +17 B (+0.0%)
module 381 kB 381 kB +17 B (+0.0%)
react-native 381 kB 381 kB +17 B (+0.0%)
@firebase/rules-unit-testing
Type Base (fe44715) Merge (f4a8fb3) Diff
main 12.3 kB 12.3 kB -10 B (-0.1%)

`bundle`

Type	Base (fe44715)	Merge (f4a8fb3)	Diff
firestore (CSI Auto Indexing Disable and Delete)	272 kB	272 kB	+17 B (+0.0%)
firestore (CSI Auto Indexing Enable)	272 kB	272 kB	+17 B (+0.0%)
firestore (Persistence)	303 kB	303 kB	+17 B (+0.0%)
firestore (Query Cursors)	249 kB	249 kB	+17 B (+0.0%)
firestore (Query)	246 kB	246 kB	+17 B (+0.0%)
firestore (Read data once)	234 kB	234 kB	+17 B (+0.0%)
firestore (Read Write w Persistence)	328 kB	328 kB	+17 B (+0.0%)
firestore (Realtime updates)	236 kB	236 kB	+17 B (+0.0%)
firestore (Transaction)	214 kB	214 kB	+17 B (+0.0%)
firestore (Write data)	213 kB	213 kB	+17 B (+0.0%)

`firebase`

Type	Base (fe44715)	Merge (f4a8fb3)	Diff
firebase-app.js	103 kB	101 kB	-2.66 kB (-2.6%)
firebase-compat.js	794 kB	794 kB	+17 B (+0.0%)
firebase-firestore-compat.js	346 kB	346 kB	+17 B (+0.0%)
firebase-firestore.js	440 kB	440 kB	+17 B (+0.0%)

Test Logs

Base (fe44715): https://github.com/firebase/firebase-js-sdk/actions/runs/11481957480
Merge (f4a8fb3): https://github.com/firebase/firebase-js-sdk/actions/runs/11484487780

https://storage.googleapis.com/firebase-sdk-metric-reports/4n1k9iPGMZ.html

google-oss-bot · 2024-10-09T17:28:34Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- addDoc
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 132 kB 132 kB +17 B (+0.0%)
  size-with-ext-deps 204 kB 204 kB +17 B (+0.0%)
- clearIndexedDbPersistence
- deleteDoc
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 122 kB 122 kB +17 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +17 B (+0.0%)
- disableNetwork
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 111 kB 111 kB +17 B (+0.0%)
  size-with-ext-deps 183 kB 183 kB +17 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 187 kB 187 kB +17 B (+0.0%)
  size-with-ext-deps 258 kB 258 kB +17 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 222 kB 223 kB +17 B (+0.0%)
  size-with-ext-deps 295 kB 295 kB +17 B (+0.0%)
- enableNetwork
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 111 kB 111 kB +17 B (+0.0%)
  size-with-ext-deps 183 kB 183 kB +17 B (+0.0%)
- executeWrite
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 121 kB 121 kB +17 B (+0.0%)
  size-with-ext-deps 193 kB 193 kB +17 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 119 kB 119 kB +17 B (+0.0%)
  size-with-ext-deps 190 kB 190 kB +17 B (+0.0%)
- getCountFromServer
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 119 kB 119 kB +17 B (+0.0%)
  size-with-ext-deps 191 kB 191 kB +17 B (+0.0%)
- getDoc
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 153 kB 153 kB +17 B (+0.0%)
  size-with-ext-deps 225 kB 225 kB +17 B (+0.0%)
- getDocFromServer
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 153 kB 153 kB +17 B (+0.0%)
  size-with-ext-deps 225 kB 225 kB +17 B (+0.0%)
- getDocs
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 154 kB 154 kB +17 B (+0.0%)
  size-with-ext-deps 226 kB 226 kB +17 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 154 kB 154 kB +17 B (+0.0%)
  size-with-ext-deps 226 kB 226 kB +17 B (+0.0%)
- loadBundle
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 120 kB 120 kB +17 B (+0.0%)
  size-with-ext-deps 192 kB 192 kB +17 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 105 kB 105 kB +17 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +17 B (+0.0%)
- onSnapshot
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 155 kB 155 kB +17 B (+0.0%)
  size-with-ext-deps 227 kB 227 kB +17 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 144 kB 144 kB +17 B (+0.0%)
  size-with-ext-deps 216 kB 216 kB +17 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 183 kB 183 kB +17 B (+0.0%)
  size-with-ext-deps 255 kB 255 kB +17 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 218 kB 218 kB +17 B (+0.0%)
  size-with-ext-deps 290 kB 290 kB +17 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 182 kB 182 kB +17 B (+0.0%)
  size-with-ext-deps 254 kB 254 kB +17 B (+0.0%)
- runTransaction
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 132 kB 132 kB +17 B (+0.0%)
  size-with-ext-deps 204 kB 204 kB +17 B (+0.0%)
- setDoc
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 131 kB 131 kB +17 B (+0.0%)
  size-with-ext-deps 203 kB 203 kB +17 B (+0.0%)
- updateDoc
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 132 kB 132 kB +17 B (+0.0%)
  size-with-ext-deps 203 kB 204 kB +17 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 111 kB 111 kB +17 B (+0.0%)
  size-with-ext-deps 183 kB 183 kB +17 B (+0.0%)
- writeBatch
  Size
  Type Base (fe44715) Merge (f4a8fb3) Diff
  size 134 kB 134 kB +17 B (+0.0%)
  size-with-ext-deps 205 kB 205 kB +17 B (+0.0%)

Test Logs

Base (fe44715): https://github.com/firebase/firebase-js-sdk/actions/runs/11481957480
Merge (f4a8fb3): https://github.com/firebase/firebase-js-sdk/actions/runs/11484487780

https://storage.googleapis.com/firebase-sdk-metric-reports/7GyawvYStN.html

.changeset/large-snakes-march.md

package.json

packages/rules-unit-testing/src/impl/discovery.ts

repo-scripts/size-analysis/rollup.config.js

…operty" This reverts commit c58e63b.

yuchenshi

Approval for rules-unit-testing (with action items)

packages/rules-unit-testing/src/impl/discovery.ts

packages/rules-unit-testing/test/impl/discovery.test.ts

hsubox76

Thanks for doing this! Really thorough job on the prune-dts overhaul.

dconeybe · 2024-10-23T17:25:59Z

@dlarocque Is there anything specific that you wanted me to look at in this PR, like specific files?

dlarocque · 2024-10-23T17:42:48Z

@dlarocque Is there anything specific that you wanted me to look at in this PR, like specific files?

I believe the only notable changes to Firestore are:

FirestoreDataConverter cast in tests: https://github.com/firebase/firebase-js-sdk/pull/8561/files#diff-0b88a866f15f8bbe13d33b4bacd5fd2dec6e13e36841f5e9b602d04b8b4f062a
Moving from ReadableStreamReader to ReadableStreamDefaultReader (one example: https://github.com/firebase/firebase-js-sdk/pull/8561/files#diff-102356186ffba50cc57b1ae7b274f07477f12243bfdd5b9dcf3b72820153f27f)

I don't think there should be any problems with these, I'm just making sure I don't accidentally introduce any breaking changes since I'm not familiar with Firestore.

dconeybe

Firestore changes LGTM.

egilmorez

Doc changes LG, thanks!

dlarocque force-pushed the dl/ts5 branch from 56b532c to ddd4dad Compare October 9, 2024 17:05

dlarocque force-pushed the dl/ts5 branch from 7738451 to 0f491e2 Compare October 16, 2024 19:16

dlarocque marked this pull request as ready for review October 16, 2024 20:16

dlarocque requested review from a team, Xiaoshouzi-gh, aashishpatil-g, avolkovi, erikeldridge, hsubox76, jposuna, lisajian, maneesht, sam-gc, tonyjhuang, yoyomyo, yuchenshi and zwu52 as code owners October 16, 2024 20:16

dlarocque requested a review from DellaBitta October 17, 2024 17:23

Base automatically changed from v11 to main October 17, 2024 21:07

hsubox76 requested review from a team as code owners October 17, 2024 21:07

DellaBitta reviewed Oct 18, 2024

View reviewed changes

.changeset/large-snakes-march.md Outdated Show resolved Hide resolved

dlarocque and others added 4 commits October 18, 2024 12:15

Updgrade to TS5

42ab67f

Remove passes of decorators to TS factory functions

7aa5fa2

Format

df4da35

Update TS in packages that used older TS versions

d93358a

dlarocque added 2 commits October 21, 2024 14:08

Disable import/no-extraneous-dependencies for auth recaptcha tests

b82f2b6

Explicitly type Firestore data converter in type tests

b19aebd

DellaBitta reviewed Oct 21, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

DellaBitta reviewed Oct 21, 2024

View reviewed changes

packages/rules-unit-testing/src/impl/discovery.ts Outdated Show resolved Hide resolved

repo-scripts/size-analysis/rollup.config.js Show resolved Hide resolved

dlarocque and others added 6 commits October 21, 2024 15:35

Downgrade @types/node to 18.19.57

7aa755a

Revert "Convert EmulatorConfig's HostAndPort to be an optional pr…

aa51e66

…operty" This reverts commit c58e63b.

Don't throw an error in case where only one of host or port are defines

db3b0d5

Merge branch 'main' into dl/ts5

2b830aa

Throw error if only one of host or port are defined

e7b9b12

Update API reports

c27254f

dlarocque requested a review from DellaBitta October 22, 2024 18:01

yuchenshi approved these changes Oct 23, 2024

View reviewed changes

packages/rules-unit-testing/src/impl/discovery.ts Outdated Show resolved Hide resolved

packages/rules-unit-testing/test/impl/discovery.test.ts Show resolved Hide resolved

dlarocque and others added 2 commits October 22, 2024 22:02

Add outer host and port check, and move tests back

e27616b

Merge branch 'main' into dl/ts5

fcc03ad

hsubox76 approved these changes Oct 23, 2024

View reviewed changes

Update devsite docs

d693bfd

dlarocque requested review from MarkDuckworth, dconeybe, egilmorez and wu-hui October 23, 2024 16:57

DellaBitta approved these changes Oct 23, 2024

View reviewed changes

dconeybe approved these changes Oct 23, 2024

View reviewed changes

egilmorez approved these changes Oct 25, 2024

View reviewed changes

dlarocque merged commit e577a40 into main Oct 25, 2024

dlarocque deleted the dl/ts5 branch October 25, 2024 12:24

This was referenced Oct 25, 2024

Remove modifiers from compat overloads #8604

Merged

Remove unused convertPropertiesForEnclosingClass #8618

Merged

firebase locked and limited conversation to collaborators Nov 25, 2024

Conversation

dlarocque commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/rules-unit-testing

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

addDoc

clearIndexedDbPersistence

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromServer

getDocs

getDocsFromServer

loadBundle

memoryLocalCache

onSnapshot

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

updateDoc

waitForPendingWrites

writeBatch

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuchenshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

dconeybe commented Oct 23, 2024

Uh oh!

dlarocque commented Oct 23, 2024

Uh oh!

dconeybe left a comment

Choose a reason for hiding this comment

Uh oh!

egilmorez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dlarocque commented Oct 9, 2024 •

edited

Loading

changeset-bot bot commented Oct 9, 2024 •

edited

Loading

google-oss-bot commented Oct 9, 2024 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/rules-unit-testing`

`bundle`

`firebase`

google-oss-bot commented Oct 9, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`addDoc`

`clearIndexedDbPersistence`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`loadBundle`

`memoryLocalCache`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`updateDoc`

`waitForPendingWrites`

`writeBatch`