Merged
Conversation
🦋 Changeset detectedLatest commit: 939af36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
jamesdaniels
commented
Dec 5, 2024
jamesdaniels
commented
Dec 10, 2024
cc7a691 to
2c6344c
Compare
jamesdaniels
commented
Feb 26, 2025
DellaBitta
approved these changes
Feb 26, 2025
Contributor
DellaBitta
left a comment
There was a problem hiding this comment.
Some nits and questions, but approved overall.
packages/util/postinstall.js
Outdated
| .then(getFullConfig) | ||
| .catch(handleUnexpectedError) | ||
| .then(async config => { | ||
| const emulatorHosts = { |
Contributor
There was a problem hiding this comment.
Clarification: does this execute if partialConfig is undefined (and subsequently fullConfig)?
Member
Author
There was a problem hiding this comment.
It does, the idea is to wipe out any hardcoded config from prior runs. The Firebase CLI will trip this script during either a Hosting deploy or emulator start.
DellaBitta
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
postinstallstep to@firebase/utilwhich hardcodes autoinit defaults into@firebase/util/dist/postinstall.(m)jsfor both CJS and ESM variants go/firestack-autoinit.Hardcoding is important since environment variable substitution doesn't dive into a developer's
node_modulesfolder. This gives us a framework agnostic way to inject configuration and is a more robust solution than the experimental autoinit methods provided by Web Frameworks go/firebase-api-client-autoinit. Once this lands, we'll backport to Hosting and Functions and aim to deprecate the other autoinit methods.I know
postinstall.jsis verbose but wanted to ensure it is compatible with the Node >= 18, has robust messaging, and fails open—e.g, overridespostinstall.(m)jssuch that it disables autoinit on failure.