Skip to content

Introduce Safari browser testing#8396

Closed
dlarocque wants to merge 13 commits intomainfrom
dlarocque/karma-safari
Closed

Introduce Safari browser testing#8396
dlarocque wants to merge 13 commits intomainfrom
dlarocque/karma-safari

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jul 26, 2024

This is part of an effort to bring back cross-browser testing to the SDK.

This PR includes a custom Karma plugin, karma-safari-launcher, that is forked from https://github.com/karma-runner/karma-safari-launcher. The original plugin is no longer maintained, and has been broken since 2018. This custom plugin fixes the main issue with the previous plugin, where a file picker dialog is opened when Safari is launched, since we attempt to open a file that is opened outside of the Safari data directory (Library/Containers/com.apple.Safari/Data). To fix the issue, we open an HTML trampoline in the Safari data directory, that then redirects us to the URL where the karma tests are hosted.

@dlarocque dlarocque requested review from DellaBitta and hsubox76 July 26, 2024 15:19
@dlarocque dlarocque requested a review from a team as a code owner July 26, 2024 15:20
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 02721e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jul 26, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (c6a8851)Merge (4ddb6a5)Diff
    browser18.3 kB18.3 kB+1 B (+0.0%)
    esm524.0 kB24.0 kB+1 B (+0.0%)
    main25.1 kB25.1 kB+1 B (+0.0%)
    module18.3 kB18.3 kB+1 B (+0.0%)

  • bundle

    46 size changes

    TypeBase (c6a8851)Merge (4ddb6a5)Diff
    analytics (logEvent)44.5 kB44.5 kB+1 B (+0.0%)
    app-check (CustomProvider)37.4 kB37.4 kB+1 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.9 kB39.9 kB+1 B (+0.0%)
    app-check (ReCaptchaV3Provider)39.9 kB39.9 kB+1 B (+0.0%)
    auth (Anonymous)76.1 kB76.1 kB+1 B (+0.0%)
    auth (EmailAndPassword)84.4 kB84.4 kB+1 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB+1 B (+0.0%)
    auth (GooglePopup)100 kB100 kB+1 B (+0.0%)
    auth (GoogleRedirect)100 kB100 kB+1 B (+0.0%)
    auth (Phone)86.8 kB86.8 kB+1 B (+0.0%)
    database (Append to a list of data)149 kB149 kB+1 B (+0.0%)
    database (Filtering data)148 kB148 kB+1 B (+0.0%)
    database (Listen for child events)164 kB164 kB+1 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+1 B (+0.0%)
    database (Listen for value events)164 kB164 kB+1 B (+0.0%)
    database (Read data once)164 kB164 kB+1 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+1 B (+0.0%)
    database (Sort data)150 kB150 kB+1 B (+0.0%)
    database (Write data)148 kB148 kB+1 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)270 kB270 kB+1 B (+0.0%)
    firestore (CSI Auto Indexing Enable)270 kB270 kB+1 B (+0.0%)
    firestore (Persistence)305 kB305 kB+1 B (+0.0%)
    firestore (Query Cursors)242 kB242 kB+1 B (+0.0%)
    firestore (Query)240 kB240 kB+1 B (+0.0%)
    firestore (Read data once)228 kB228 kB+1 B (+0.0%)
    firestore (Read Write w Persistence)325 kB325 kB+1 B (+0.0%)
    firestore (Realtime updates)230 kB230 kB+1 B (+0.0%)
    firestore (Transaction)207 kB207 kB+1 B (+0.0%)
    firestore (Write data)207 kB207 kB+1 B (+0.0%)
    firestore-lite (Query Cursors)91.3 kB91.3 kB+1 B (+0.0%)
    firestore-lite (Query)87.4 kB87.4 kB+1 B (+0.0%)
    firestore-lite (Read data once)62.9 kB62.9 kB+1 B (+0.0%)
    firestore-lite (Transaction)88.1 kB88.1 kB+1 B (+0.0%)
    firestore-lite (Write data)72.5 kB72.5 kB+1 B (+0.0%)
    functions (call)32.0 kB32.0 kB+1 B (+0.0%)
    messaging (send + receive)46.9 kB46.9 kB+1 B (+0.0%)
    performance (trace)51.8 kB51.8 kB+1 B (+0.0%)
    remote-config (getAndFetch)46.3 kB46.3 kB+1 B (+0.0%)
    storage (getBytes)42.1 kB42.1 kB+1 B (+0.0%)
    storage (getDownloadURL)44.1 kB44.1 kB+1 B (+0.0%)
    storage (getMetadata)43.6 kB43.6 kB+1 B (+0.0%)
    storage (list + listAll)43.0 kB43.0 kB+1 B (+0.0%)
    storage (updateMetadata)43.9 kB43.9 kB+1 B (+0.0%)
    storage (uploadBytes)48.7 kB48.7 kB+1 B (+0.0%)
    storage (uploadBytesResumable)58.7 kB58.7 kB+1 B (+0.0%)
    storage (uploadString)48.9 kB48.9 kB+1 B (+0.0%)

  • firebase

    TypeBase (c6a8851)Merge (4ddb6a5)Diff
    firebase-app-compat.js31.8 kB31.8 kB+1 B (+0.0%)
    firebase-app.js103 kB103 kB+1 B (+0.0%)
    firebase-compat.js788 kB788 kB+1 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js93.6 kB93.6 kB+1 B (+0.0%)
    firebase-performance-standalone-compat.js70.8 kB70.8 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N2iZQsDHdi.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Jul 26, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (150,199 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y5BkKUXVjh.html

@dlarocque dlarocque force-pushed the dlarocque/karma-safari branch 4 times, most recently from 2a43d59 to 5b2cad7 Compare July 29, 2024 19:48
@dlarocque dlarocque force-pushed the dlarocque/karma-safari branch 2 times, most recently from b2e32d2 to e8d9bd6 Compare July 30, 2024 15:19
@dlarocque dlarocque marked this pull request as draft July 30, 2024 19:08
hsubox76
hsubox76 reviewed Jul 30, 2024
View reviewed changes
@dlarocque dlarocque force-pushed the dlarocque/karma-safari branch from e8d9bd6 to 849be6a Compare August 22, 2024 20:43
@dlarocque dlarocque mentioned this pull request Sep 9, 2024
Merged
@dlarocque dlarocque closed this Sep 24, 2024
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
@hsubox76 hsubox76 deleted the dlarocque/karma-safari branch February 18, 2026 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka will be requested when the pull request is marked ready for review pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat will be requested when the pull request is marked ready for review mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam will be requested when the pull request is marked ready for review NhienLam is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlarocque @google-oss-bot @hsubox76