Conversation
|
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (285,279 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
prameshj
reviewed
Aug 23, 2023
prameshj
approved these changes
Aug 23, 2023
hsubox76
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently pin Chrome v110 on CI as tests in https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/test/integration/webdriver/redirect.test.ts became flaky on version 111.
This change fixes these flaky tests and pins Chrome v114.
Why do we pin v114 but not install the latest Chrome version?
https://chromedriver.chromium.org/downloads only goes up to version 114, so ChromeDriver installation will fail with higher versions:
"No such object: chromedriver/LATEST_RELEASE_115.0.5790". According to that website, starting with version 115 these JSON endpoints should be used to determine compatible versions and download urls. Hence, we will pin v114 for now and update the script to install the latest ChromeDriver in another PR.Internal bug: b/297380444
I've tested this locally with the latest Chrome v116. All auth webdriver tests passed 7 times out of 7 runs.
CI tests with Chrome v114 also pass.