Skip to content

Tests for the v9 implementation of UpdateData<T>#7319

Merged
MarkDuckworth merged 4 commits intomasterfrom
markduckworth/nested-update-data-v9
Jun 30, 2023
Merged

Tests for the v9 implementation of UpdateData<T>#7319
MarkDuckworth merged 4 commits intomasterfrom
markduckworth/nested-update-data-v9

Conversation

@MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented May 22, 2023

Tests in this PR are being added to ensure that UpdateData does not regress. These tests do not evaluate any JS implementation, they only evaluate TS types, therefore you do not see any meaningful expect statements in these tests. Type behavior is asserted during the TS compilation, if the tests do not build then the tests are failing.

Empty assertions expect(true).to.be.true are included to avoid possible flagging of tests that do not perform assertions.

@MarkDuckworth MarkDuckworth requested review from a team as code owners May 22, 2023 23:22
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 84d5cad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarkDuckworth MarkDuckworth mentioned this pull request May 22, 2023
Merged
@google-oss-bot
Copy link
Collaborator

google-oss-bot commented May 22, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (039f05f) and merge commit (8fceac9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/E2BqqS1XqE.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented May 23, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (039f05f) and merge commit (8fceac9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lRSFH1O96z.html

dconeybe
dconeybe approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test coverage! This is fantastic to reduce the risks of regression and definitely increases the confidence that #7318 works as expected.

@dconeybe dconeybe assigned MarkDuckworth and unassigned dconeybe May 25, 2023
@MarkDuckworth MarkDuckworth merged commit b00b54b into master Jun 30, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/nested-update-data-v9 branch June 30, 2023 13:51
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@MarkDuckworth MarkDuckworth

@ehsannas ehsannas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarkDuckworth @google-oss-bot @dconeybe @ehsannas