Conversation
This comment has been minimized.
This comment has been minimized.
| default: 'https://github.com/firebase/SpecsStaging.git' | ||
|
|
||
| jobs: | ||
| package-release: |
There was a problem hiding this comment.
Add a 2nd package builder that builds with only staged and trunk pods.
The other package build was building from head.
| @@ -1,4 +0,0 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
All .gitignore should be done at the top of the repo.
| do { | ||
| print("Creating Carthage release...") | ||
| let carthagePath = | ||
| zipLocation.deletingLastPathComponent().appendingPathComponent("carthage_build") |
There was a problem hiding this comment.
Another copy of the carthage artifacts is not needed since they were already in the dedicated CarthageFirebase directory.
| // Package the Carthage distribution with the current directory structure. | ||
| let carthageDir = zipLocation.deletingLastPathComponent().appendingPathComponent("carthage") | ||
| fileManager.removeIfExists(at: carthageDir) | ||
| let output = carthageDir.appendingPathComponents([artifacts.firebaseVersion, "latest"]) |
There was a problem hiding this comment.
Remove redundant latest in the path to eliminate a release process step.
| let remainingPods = installedPods.filter { | ||
| $0.key != "FirebaseAnalytics" && | ||
| $0.key != "FirebaseCore" && | ||
| $0.key != "FirebaseCoreDiagnostics" && |
There was a problem hiding this comment.
These were already skipped for the zip build, but not for the Carthage build.
scripts/build_zip.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| build_head_option= |
There was a problem hiding this comment.
Two different option sets for building from head versus building release candidates
There was a problem hiding this comment.
I don't think that we need to "define" these in bash ahead of time like we would in Swift/ObjC - unless this is best practice and I'm missing something.
| Pod("FirebaseCoreDiagnostics"), | ||
| Pod("FirebaseCore"), | ||
| Pod("FirebaseInstallations"), | ||
| Pod("FirebaseCoreDiagnostics", zip: true), |
There was a problem hiding this comment.
Otherwise we always build these three from a published podspec and never from head.
scripts/build_zip.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| build_head_option= |
There was a problem hiding this comment.
I don't think that we need to "define" these in bash ahead of time like we would in Swift/ObjC - unless this is best practice and I'm missing something.
Adds packaging of tagged release build - either from SpecsStaging or if already published from the CDN. The version is specified in the FirebaseManifest.
Running the quickstarts probably isn't necessary since presumably they have already been tested with the master build. Also, I don't know of a good way to set that up without a lot of duplication.
Along the way, I found a few other miscellaneous issue. See the embedded review comments.
Confirmed expected diffs after temporarily changing some public headers in https://github.com/firebase/firebase-ios-sdk/actions/runs/857702464.
I also ran into and diagnosed an issue where Firestore stopped
pod installinglocally for me because of agitissue. Details at https://stackoverflow.com/a/67550246/556617 and internally at b/188526329.Companion CL is cl/374304372
Fix #8082
#no-changelog