Skip to content

Update Carthage distribution for 8.0.0#8087

Merged
paulb777 merged 1 commit intomasterfrom
pb-carthage-update-800
May 17, 2021
Merged

Update Carthage distribution for 8.0.0#8087
paulb777 merged 1 commit intomasterfrom
pb-carthage-update-800

Conversation

@paulb777
Copy link
Copy Markdown
Member

@paulb777 paulb777 commented May 16, 2021 •
edited
Loading

This PR is the resulting build distribution from the fixes in #8084

Fix #7039
Fix #7576

Will publish the Carthage update when #8084 and this PR are approved.

Testing:
Unzipped the archive from https://github.com/firebase/firebase-ios-sdk/actions/runs/845683211

Edited the json files in a local directory:

Screen Shot 2021-05-15 at 5 57 09 PM

Edited the sample in Carthage.md like

Screen Shot 2021-05-15 at 6 14 40 PM

Verified carthage update succeeded.

@google-cla google-cla bot added the cla: yes label May 16, 2021
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented May 16, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.78% (4f00074) to 68.77% (73911aa) by -0.01%.

    Filename Base (4f00074) Head (73911aa) Diff
    FIRAuthKeychainServices.m 60.16% 59.38% -0.78%

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 60.91% (4f00074) to 75.57% (73911aa) by +14.66%.

    Filename Base (4f00074) Head (73911aa) Diff
    FDLUtilities.m 73.48% 90.15% +16.67%
    FIRDLDefaultRetrievalProcessV2.m 14.06% 72.92% +58.85%
    FIRDLJavaScriptExecutor.m 26.28% 82.48% +56.20%
    FIRDynamicLinkNetworking.m 44.44% 80.83% +36.39%

Test Logs

@paulb777 paulb777 requested a review from ryanwilson May 17, 2021 14:04
ryanwilson
ryanwilson requested changes May 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs are 404ing for me at the moment - changes look good otherwise outside of a question about MLModelDownloader + zip/binary availability

@paulb777
Copy link
Copy Markdown
Member Author

paulb777 commented May 17, 2021

They're 404'ing because not yet published since waiting for reviews.

If we once excluded MLModelDownloader, it's no longer happening since it's already part of the 8.0.0 zip distro.

@paulb777 paulb777 force-pushed the pb-carthage-update-800 branch from 6355a73 to 73911aa Compare May 17, 2021 19:43
@paulb777
Copy link
Copy Markdown
Member Author

paulb777 commented May 17, 2021

8.0.0 is now distributed via Carthage

@paulb777 paulb777 merged commit f920f2f into master May 17, 2021
@paulb777 paulb777 deleted the pb-carthage-update-800 branch May 17, 2021 19:44
@firebase firebase locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

api: appcheck api: appdistribution api: auth api: crashlytics api: database api: dynamiclinks api: inappmessaging Firebase In App Messaging api: messaging api: performance api: remoteconfig api: storage cla: yes release-tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FR: Add xcframeworks in zip file on tagged assets list for version Carthage doesn't download Firebase binaries on Apple M1

3 participants

@paulb777 @google-oss-bot @ryanwilson