Skip to content

Missing dependency on graphql #1793

@xylo04

Description

@xylo04

I have a Renovate PR to bump from 7.0.2 to 7.0.3, but it seems like a peer dependency on GraphQL was introduced even though I'm not using any new features. k0swe/w1aw-schedule#437

Related issues

None that I found

[REQUIRED] Version info

node: v24.12.0
npm: 11.6.2
yarn: 1.22.22

firebase-functions: 7.0.3

firebase-tools: latest(?)

firebase-admin: ^13.6.0

[REQUIRED] Test case

Attempt to upgrade from firebase-functions 7.0.2 to 7.0.3, as in k0swe/w1aw-schedule#437.

[REQUIRED] Steps to reproduce

firebase emulators:exec --only firestore 'npm run test:unit'

[REQUIRED] Expected behavior

Bumping the patch version does not require new peer dependencies.

[REQUIRED] Actual behavior

My CI pipeline fails with Cannot find module 'graphql':

⚠  emulators: You are not currently authenticated so some features may not work correctly. Please run firebase login to authenticate the CLI.
i  emulators: Starting emulators: firestore
⚠  It appears you are running in a CI environment. You can avoid downloading the Firestore Emulator repeatedly by caching the /home/runner/.cache/firebase/emulators directory.
i  firestore: downloading cloud-firestore-emulator-v1.20.2.jar...

i  firestore: Firestore Emulator logging to firestore-debug.log
✔  firestore: Firestore Emulator UI websocket is running on 9150.
i  Running script: npm run test:unit

> test:unit
> npm run build && mocha --reporter spec ./build/ --recursive


> build
> tsc

Error: node_modules/firebase-functions/lib/v2/providers/dataconnect.d.ts(2,41): error TS2307: Cannot find module 'graphql' or its corresponding type declarations.
⚠  Script exited unsuccessfully (code 2)
i  emulators: Shutting down emulators.
i  firestore: Stopping Firestore Emulator
i  hub: Stopping emulator hub
i  logging: Stopping Logging Emulator

Error: Script "npm run test:unit" exited with code 2
Error: Process completed with exit code 2.

Were you able to successfully deploy your functions?

Haven't tried, TS compilation failed.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions