Skip to content

Implement POJO field reads. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikelehen merged 1 commit into from
Oct 22, 2018
Merged

Implement POJO field reads. #83

mikelehen merged 1 commit into from
Oct 22, 2018

Conversation

@mikelehen
Copy link
Contributor

@mikelehen mikelehen commented Oct 22, 2018

  • Added T get(..., Class<T>, ...) overloads for extracting fields as a custom
    class (POJO) type.

Implement POJO field reads.
2a83af5 
* Added `T get(..., Class<T>, ...)` overloads for extracting fields as a custom
  class (POJO) type.
@mikelehen mikelehen added the type: feature request New feature or request label Oct 22, 2018
@mikelehen
Copy link
Contributor Author

mikelehen commented Oct 22, 2018

FYI- I based this on my mikelehen/pojo-field-writes branch since I intended to merge them together, but I could rebase on master.

schmidt-sebastian
schmidt-sebastian approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mikelehen mikelehen merged commit e264d60 into mikelehen/pojo-field-writes Oct 22, 2018
@mikelehen mikelehen deleted the mikelehen/pojo-field-reads branch October 22, 2018 20:45
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikelehen mikelehen

Labels

size/L type: feature request New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikelehen @schmidt-sebastian @google-oss-bot