Skip to content

fix(firestore): Fix PreferRest caching issue#2040

Merged
lahirumaramba merged 1 commit intomasterfrom
lm-fix-fs
Jan 13, 2023
Merged

fix(firestore): Fix PreferRest caching issue#2040
lahirumaramba merged 1 commit intomasterfrom
lm-fix-fs

Conversation

@lahirumaramba
Copy link
Copy Markdown
Member

@lahirumaramba lahirumaramba commented Jan 13, 2023 •
edited
Loading

  • Fixed a caching issue when a non-empty FirestoreSettings object is passed to initializeFirestore(...)
  • Improved test coverage for initializeFirestore()

Before:

initializeFirestore(app)
getFirestore(app) // works!

---

initializeFirestore(app, {})
getFirestore(app) // works!

---

initializeFirestore(app, { preferRest: true })
getFirestore(app) // throws `firestore/failed-precondition` error!

Related to: #1901

MarkDuckworth
MarkDuckworth approved these changes Jan 13, 2023
View reviewed changes
Copy link
Copy Markdown

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lahirumaramba lahirumaramba merged commit 6061ff6 into master Jan 13, 2023
@lahirumaramba lahirumaramba deleted the lm-fix-fs branch January 13, 2023 23:25
This was referenced Jan 17, 2023
Merged
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarkDuckworth MarkDuckworth

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lahirumaramba @MarkDuckworth @alexander-fenster @hsubox76