Skip to content

fix(fcm): Correctly map the string representation of the Android Config normal priority.#452

Merged
jonathanedey merged 3 commits into
firebase:masterfrom
zSlicker:AndroidConfigSetNormalPriority
Apr 11, 2025
Merged

fix(fcm): Correctly map the string representation of the Android Config normal priority.#452
jonathanedey merged 3 commits into
firebase:masterfrom
zSlicker:AndroidConfigSetNormalPriority

Conversation

@zSlicker

@zSlicker zSlicker commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@jonathanedey jonathanedey self-requested a review March 18, 2025 18:43

@jonathanedey jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @zSlicker for your contribution!

@jonathanedey

jonathanedey commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Hi @zSlicker , could you push an empty commit here to re trigger our github action tests?
git commit --allow-empty -m "Empty commit message"

@jonathanedey

Copy link
Copy Markdown
Contributor

Hi @zSlicker, pinging here again since I didn't see the empty commit here. Could you push that empty commit to this PR?

@zSlicker

Copy link
Copy Markdown
Contributor Author

@jonathanedey done

@jonathanedey jonathanedey changed the title Android Config does not set a normal priority. fix(fcm): Correctly map the string representation of the Android Config normal priority. Apr 11, 2025
@jonathanedey jonathanedey merged commit c41aff2 into firebase:master Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants