Skip to content

AuthUI First-party support for Activity Result APIs#1918

Merged
samtstern merged 6 commits into
firebase:version-7.2.0-devfrom
jossiwolf:jw/auth-activity-result-apis
Mar 4, 2021
Merged

AuthUI First-party support for Activity Result APIs#1918
samtstern merged 6 commits into
firebase:version-7.2.0-devfrom
jossiwolf:jw/auth-activity-result-apis

Conversation

@jossiwolf

@jossiwolf jossiwolf commented Mar 3, 2021 •
edited by samtstern
Loading

Copy link
Copy Markdown
Contributor

See #1916.

@samtstern, there are is a looot of internal code that could/should be migrated. Do you want that as part of this PR? It'd probably take a bit but it's up to you!

I'm guessing additional work in the snippets repo is needed, right?

I haven't written Java in quiiiite a bit so any feedback on Java code style is appreciated!

Cheers!

@jossiwolf jossiwolf requested a review from samtstern as a code owner March 3, 2021 20:24
@google-cla google-cla Bot added the cla: yes label Mar 3, 2021
thatfiredev
thatfiredev reviewed Mar 4, 2021
View reviewed changes
Comment thread auth/src/main/java/com/firebase/ui/auth/FirebaseAuthUIActivityResultContract.java Outdated
@thatfiredev

thatfiredev commented Mar 4, 2021

Copy link
Copy Markdown
Member

@jossiwolf Our GH Actions workflow is failing due to lint errors. You can run gradlew checkstyle locally to detect those before pushing a commit.

@jossiwolf

jossiwolf commented Mar 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I swear checkstyle ran on my machine🤔😂 I'll upload a patch later!

samtstern
samtstern approved these changes Mar 4, 2021
View reviewed changes

@samtstern samtstern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thanks @jossiwolf. Just see my comments on the one thread about the IntentBuilder thing and let me know what you you think.

Also as far as I can tell we can launch this in 7.2.0 right?

@samtstern samtstern added this to the 7.2.0 milestone Mar 4, 2021
@jossiwolf

jossiwolf commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

@samtstern Lovely, thanks for the quick review! Yup this should be ready to be launched with 7.2.0 :) There might be some additional work needed in the snippets repo to make sure the docs are up to date then, right? How do you want to go about that?

@samtstern samtstern changed the base branch from master to version-7.2.0-dev March 4, 2021 14:15
@samtstern

samtstern commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

@jossiwolf I just changed this to target the 7.2.0-dev branch. As soon as you rebase or merge in the base then we can merge this!

As for snippets we can handle that when 7.2.0 is actually released. No need to worry about it for now.

@jossiwolf

jossiwolf commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

Oh perfect, I'll rebase that once CI went through successfully!

@jossiwolf jossiwolf force-pushed the jw/auth-activity-result-apis branch from fb2e1c9 to c430a42 Compare March 4, 2021 14:27
@samtstern samtstern merged commit c7f188d into firebase:version-7.2.0-dev Mar 4, 2021
@jossiwolf jossiwolf deleted the jw/auth-activity-result-apis branch March 4, 2021 16:42
@thatfiredev thatfiredev mentioned this pull request Mar 12, 2021
Closed
@samtstern samtstern mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatfiredev thatfiredev thatfiredev left review comments

+1 more reviewer

@samtstern samtstern samtstern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Activity Result APIs for AuthUI

3 participants

@jossiwolf @thatfiredev @samtstern