Skip to content

pagerjs AMD support replies on global $ variable #135

@3cp

Description

@3cp

Hi Finnsson,
The pager.js amd implementation relies on jQuery lib registers itself as the global variable "$", which is true by default. But developer may choose to use jQuery noConflict to turn off global variables "$" and "jQuery" to conform with the idea of AMD.
http://requirejs.org/docs/jquery.html#noconflictmap

Should not this

define('pager', ['knockout', 'jquery'], function (ko) {
    return pagerJsModule($, ko);
});

be updated to

define('pager', ['knockout', 'jquery'], function (ko, $) { ... });

?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions