service.c/parse_cmdline_args: handle loooooong arguments #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/troglobit/finit/blob/2760616c73af1284bd71ae9aa8226c3da3ff8544/src/service.c#L1420
prevandsvc->args[...]are compared butprevhas less bytes available thansvc->args[...]does, which can result in truncated data being compared to determine if a service is dirtyfor example:
this results in
finitmarking some of my services as dirty every time i runinitctl reloadby giving
prevthe same size as what it will be compared against we can ensure a valid comparisonfully tested on my machine and ready to go 👍