Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Bumps the package version, loosens a type definition, and adds dependency resolutions to address audit fixes.
- Updated the exported
versionconstant to5.0.0-1. - Modified
Subscriptiontype to allowundefinedvalues. - Introduced a
resolutionssection inpackage.jsonto pin downstream dependencies.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/version.ts | Bumped version string from "4.20.10" to "5.0.0-1". |
| src/types.ts | Expanded Subscription type to `boolean |
| package.json | Added resolutions field to pin specific dependency versions. |
Comments suppressed due to low confidence (1)
src/types.ts:1
- With the updated Subscription type accepting undefined, add unit tests covering both
true,false, andundefinedcases to ensure correct behavior.
export type Subscription = { [key: string]: boolean | undefined };
| @@ -1,4 +1,4 @@ | |||
| export type Subscription = { [key: string]: boolean }; | |||
| export type Subscription = { [key: string]: boolean | undefined }; | |||
There was a problem hiding this comment.
The Subscription type now allows undefined values; consider adding comments or updating documentation to clarify when a subscription can be undefined.
| "dependencies": { | ||
| "@babel/runtime": "^7.10.0" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
The resolutions field is specific to Yarn v1; please document this requirement in the README or switch to npm’s overrides for npm v8+ compatibility.
Suggested change
| "resolutions": { | |
| "overrides": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a few things with RFF, too