Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from Flow to TypeScript, updating imports, build/test configurations, and snapshots accordingly
- Removes Flow annotations, plugins, and config files
- Introduces TypeScript support in Rollup, Babel, ESLint, Jest, and npm scripts
- Updates imports/extensions, inline snapshots, and adds new TS constants
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/filterFieldState.test.ts | Adjusts import to drop “.js” extension for TS resolution |
| src/fieldSubscriptionItems.ts | Removes // @flow and adds as const assertion to the array |
| src/constants.ts | Adds new TypeScript constants file |
| src/constants.js | Deletes legacy Flow-based constants file |
| src/FinalForm.submission.test.ts | Refreshes Jest inline snapshots for TS syntax |
| rollup.config.mjs | Replaces Flow plugin with TypeScript plugin, updates input to TS |
| package.json | Bumps dependencies, adds TS presets, updates test/coverage scripts |
| package-scripts.js | Refactors npm script definitions, placeholders for TS declarations |
| .flowconfig | Removes obsolete Flow configuration |
| .eslintrc | Adds @typescript-eslint parser and plugin |
| .babelrc | Switches from Flow to TypeScript preset |
2842946 to
52c4b4f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts the codebase from Flow to TypeScript, removing Flow-specific configurations and dependencies while updating build, test, and lint setups accordingly.
- Removed Flow annotations and configuration files
- Added TypeScript configurations and updated relevant build/lint/test settings
- Updated dependency versions and project scripts to support TypeScript
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/fieldSubscriptionItems.ts | Removed Flow annotation and added an "as const" assertion |
| src/constants.ts | Introduced TypeScript constants |
| src/constants.js | Removed now-obsolete Flow-based constants |
| src/FinalForm.submission.test.ts | Updated inline snapshots to reflect TS conversion changes |
| rollup.config.mjs | Removed Flow plugin and added TypeScript plugin configuration |
| package.json | Updated dependency versions and removed Flow-related packages |
| package-scripts.js | Updated scripts to eliminate Flow tasks and type copying |
| .github/workflows/ci.yml | Updated Node.js version to 22 |
| .flowconfig | Removed Flow configuration file |
| .eslintrc | Configured ESLint for TypeScript, including overrides |
| .babelrc | Replaced Flow preset with TypeScript preset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue. Adiós, Flow!