Assembly isolation opt-in at dotnet-script level#637
Merged
filipw merged 4 commits intodotnet-script:masterfrom Aug 26, 2021
hrumhurum:gp-feature-a
Merged
Assembly isolation opt-in at dotnet-script level#637filipw merged 4 commits intodotnet-script:masterfrom hrumhurum:gp-feature-a
filipw merged 4 commits intodotnet-script:masterfrom
hrumhurum:gp-feature-a
Conversation
… in assembly-isolated mode.
…ion is opt-in.
Collaborator
|
@hrumhurum The build failed because of some network issue. I can't find where to restart the build. Can you just push an empty commit to restart?
|
seesharper
approved these changes
Aug 26, 2021
Collaborator
seesharper
left a comment
There was a problem hiding this comment.
Looks good, thanks 👍
Merged
Collaborator
|
@hrumhurum Just wanted to say thanks for reacting so quickly to the problem. 👍😊 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to difficulties and relative immaturity of
AssemblyLoadContextsupport, assembly isolation should be opt-in atdotnet-scriptlevel for now.This PR implements this by introducing
--isolated-load-contextcommand-line option indotnet-script.