Test issues when running from a folder containing a space character in its name#629
Merged
filipw merged 6 commits intodotnet-script:masterfrom Aug 18, 2021
hrumhurum:gp-fix-a
Merged
Test issues when running from a folder containing a space character in its name#629filipw merged 6 commits intodotnet-script:masterfrom hrumhurum:gp-fix-a
filipw merged 6 commits intodotnet-script:masterfrom
hrumhurum:gp-fix-a
Conversation
… a space character in its name.
Member
|
Thanks for catching this!
One note here, I would prefer to inline the escaping logic because the dependency model package ships with OmniSharp and we intentionally do not want to create extra dependencies for OmniSharp. |
Contributor
Author
Done. The corresponding code is now inlined. |
seesharper
approved these changes
Aug 17, 2021
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the DotNet.Script solution resides in a folder containing a space character in its name, an avalanche of test failures occurs due to the absence of escaping of command line arguments.
The enclosed pull request fixes all those issues.
Besides tests, there was a similar issue in
DotNetRestorerclass that was fixed as well by employing a batte-tested string escaping algorithm from Gapotchenko.FX.Diagnostics.CommandLine package.An intricate detail of NuGet's
-sargument is that it may end with\character (e.g. the last separator in a folder path), so such a naive escaping approach as$"-s \"{s}\""would not work here, as it will cause an unanticipated escape of the escape character". Hence the usage of a proper escape function here to isolate the customer-supplied data.