Skip to content

Conversation

@seesharper
Copy link
Collaborator

This PR bumps the following packages to 5.0.0

  • System.Configuration.ConfigurationManager
  • System.Text.Encoding.CodePages
  • Microsoft.Extensions.Logging.Console

These packages does not affect OmniSharp since they are only used in the Dotnet.Script and Dotnet.Script.Core projects.

Also added a test for #613 which is fixed by this PR.

All three packages are netstandard2.0 compliant and can be used from all target frameworks (netcoreapp2.1, netcoreapp3.1 and net5.0)

Finally the tests for netcoreapp2.1 and netcoreapp3.1 has been enabled again. We haven't tested those since we added support for net5.0 😎

@seesharper seesharper requested a review from filipw April 20, 2021 15:39
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@filipw filipw merged commit 984b9c6 into master Apr 22, 2021
@filipw filipw deleted the bump-deps branch April 22, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants