Skip to content

updated to Roslyn 3.8.0 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seesharper merged 2 commits into from
Nov 18, 2020
Merged

updated to Roslyn 3.8.0 #595

seesharper merged 2 commits into from
Nov 18, 2020

Conversation

@filipw
Copy link
Member

@filipw filipw commented Nov 17, 2020

stable is now out

@filipw filipw requested a review from seesharper November 17, 2020 09:48
seesharper
seesharper approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. While you're at it could you also update this?

https://github.com/filipw/dotnet-script/blob/35e1d7ee577b0572d715291404493aec70fbdd9a/src/Dotnet.Script.Core/ScriptPublisher.cs#L16

@filipw
Copy link
Member Author

filipw commented Nov 18, 2020

oops I missed it

seesharper
seesharper approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@seesharper seesharper merged commit b5ce1af into master Nov 18, 2020
@seesharper seesharper deleted the feature/roslyn-3.8.0 branch November 18, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seesharper seesharper seesharper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipw @seesharper