Fix loading indicator still displayed after opening out-of-scope URLs#712
Merged
filips123 merged 1 commit intofilips123:mainfrom Jul 26, 2025
Merged
Fix loading indicator still displayed after opening out-of-scope URLs#712filips123 merged 1 commit intofilips123:mainfrom
filips123 merged 1 commit intofilips123:mainfrom
Conversation
not a teapot
Owner
|
Thanks for the fix! That is quite interesting, and I also don't know why this happens. I wanted to have 418 as an easter egg, but I guess it will have to be removed. I also found that https://echo.websocket.org/.ws is quite a useful site for testing WebSockets. I think the problem is that as the link was supposed to be opened in the same tab as the original website, Firefox cancelled all ongoing requests before PWAsForFirefox could prevent the navigation. But I don't know yet how to prevent this. Maybe there is some event other than |
filips123
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still restarts websockets, which is not ideal, but it makes firefox pwas usable
I have no idea how anything works, or why it does what it does, but I saw someone on stackoverflow using
Cr.NS_BINDING_ABORTEDand tested that and it works for mehttps://stackoverflow.com/questions/30585385/firefox-extension-how-to-intercept-the-requested-url-conditionally-and-block-it