Description
Commit 192a7b4 introduces a regression on immutable-runtime,
Inside components/runtime.rs, the link method got changed from a feature to a requirement on linux, so if you try to build immutable-runtime, it will error out, because the method was not intended for that feature.
|
#[cfg(platform_linux)] |
|
pub fn link(&self) -> Result<()> { |
|
use std::fs::{copy, create_dir_all}; |
|
use std::os::unix::fs::symlink; |
|
|
|
use crate::storage::Storage; |
|
|
|
let dirs = ProjectDirs::new()?; |
|
let mut storage = Storage::load(&dirs)?; |
|
|
|
self.uninstall()?; |
Because obviously, immutable-runtime has no uninstall attribute.
|
#[cfg(not(feature = "immutable-runtime"))] |
|
pub fn uninstall(&self) -> Result<()> { |
Steps to Reproduce
Build with immutable-runtime.
Suggestion
Add immutable-runtime to Github action tests.
Additional Information
Cargo logs:
> error[E0599]: no method named `uninstall` found for reference `&Runtime` in the current scope
> --> src/components/runtime.rs:365:14
> |
> 365 | self.uninstall()?;
> | ^^^^^^^^^ method not found in `&Runtime`
Description
Commit 192a7b4 introduces a regression on
immutable-runtime,Inside components/runtime.rs, the
linkmethod got changed from a feature to a requirement onlinux, so if you try to buildimmutable-runtime, it will error out, because the method was not intended for that feature.PWAsForFirefox/native/src/components/runtime.rs
Lines 355 to 365 in 192a7b4
Because obviously,
immutable-runtimehas nouninstallattribute.PWAsForFirefox/native/src/components/runtime.rs
Lines 405 to 406 in 192a7b4
Steps to Reproduce
Build with
immutable-runtime.Suggestion
Add
immutable-runtimeto Github action tests.Additional Information
Cargo logs: