Feature/better expiring files time#2624
Merged
monkeyiq merged 3 commits intofilesender:development3from Mar 17, 2026
Merged
Conversation
monkeyiq
approved these changes
Mar 17, 2026
This was referenced Mar 17, 2026
This was referenced Mar 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: transfer expiry date picker now uses the correct time
Problem: When selecting an expiry date, the transfer expired at
00:00of the selected day (the very start), not the end. Selecting "March 17" would
expire the transfer at midnight between March 16 and March 17 — potentially
just hours after creation.
Solution: The expiry timestamp is now set to the current time-of-day
on the selected date. If you upload at 14:32 and select "March 17", the
transfer expires on March 17 at 14:32 — exactly one or more full days later.
Selecting today as the expiry date is not allowed.
Additionally, all templates that display the expiry date now show the full
datetime (date + time), so users can see the exact expiry moment.
Note: For users to see the expiry time in their own timezone rather than
the server's UTC time, the option
client_send_current_timezone_to_servershould be set to
trueinconfig.php. This option isfalseby defaultfor privacy reasons (it sends the browser's timezone as a cookie), but
enabling it is recommended for deployments where all users share the same
timezone or where showing the correct local time is a priority. Without it,
the expiry time is displayed in UTC, which may confuse users in other
timezones.
Files modified:
www/js/upload_page.js— expiry timestamp calculationtemplates/transfers_table.phptemplates/transfer_detail_page.phptemplates/transfers_guest_page.phptemplates/download_page.php