Skip to content

Php8x deprecation fixes#2623

Merged
madsi1m merged 2 commits intofilesender:development3from
madsi1m:php8_deprecation_fix
Mar 16, 2026
Merged

Php8x deprecation fixes#2623
madsi1m merged 2 commits intofilesender:development3from
madsi1m:php8_deprecation_fix

Conversation

@madsi1m
Copy link
Copy Markdown
Contributor

@madsi1m madsi1m commented Mar 16, 2026

@monkeyiq please give this a once over before merging.
Discovered this while testing Forwarding code in newer php

@madsi1m madsi1m requested a review from monkeyiq March 16, 2026 03:47
@madsi1m madsi1m merged commit 79fce64 into filesender:development3 Mar 16, 2026
5 checks passed
@monkeyiq
Copy link
Copy Markdown
Contributor

monkeyiq commented Mar 16, 2026

I hadn't tracked down what was using the $context as yet. It may be that it is being used in an, err, "context" that is not a local method?

@madsi1m
Copy link
Copy Markdown
Contributor Author

madsi1m commented Mar 16, 2026

Same! here is the exact error i saw:

{"app":"FileSender","process":"async","level":"error","message":"Error [8192]: Creation of dynamic property StorageFilesystemChunkedStream::$context is deprecated in \/filesender\/classes\/storage\/StorageFilesystemChunked.class.php on line 388","time":1773631784}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@monkeyiq monkeyiq Awaiting requested review from monkeyiq

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madsi1m @monkeyiq