fix: normalize filenames to NFC to support MacOS (NFD) unicode characters#2620
Merged
monkeyiq merged 1 commit intofilesender:developmentfrom Mar 16, 2026
Merged
fix: normalize filenames to NFC to support MacOS (NFD) unicode characters#2620monkeyiq merged 1 commit intofilesender:developmentfrom
monkeyiq merged 1 commit intofilesender:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where users on MacOS encounter an invalid_file_name error when uploading files containing unicode characters (e.g., Turkish characters like Ü, İ, Ş, or German umlauts).
MacOS uses NFD (Normalization Form Decomposed) by default for filenames. In NFD, a character like Ü is stored as two separate code points: U (U+0055) + ¨ (U+0308).
FileSender's filename validation logic in transfer.js uses XRegExp to test the filename. When it encounters these decomposed characters, the regex lastIndex check fails because it expects single-composed characters (NFC - Normalization Form Composed), leading to an incorrect "invalid filename" rejection even if the character itself is technically allowed in the configuration.
Before performing the regex validation in www/js/transfer.js, we now explicitly call file.name.normalize('NFC'). This ensures that any decomposed characters from MacOS are converted into their standard composed forms before the validation logic runs.