Skip to content

FS CLI Client: more lint#2591

Merged
monkeyiq merged 1 commit intofilesender:development3from
madsi1m:fscliclient
Mar 2, 2026
Merged

FS CLI Client: more lint#2591
monkeyiq merged 1 commit intofilesender:development3from
madsi1m:fscliclient

Conversation

@madsi1m
Copy link
Copy Markdown
Contributor

@madsi1m madsi1m commented Mar 2, 2026

More linting and put the whole thing into a class of its own

Best I can get in a short time without rewriting too much of it:

$ pylint filesender.py
************* Module filesender
filesender.py:82:0: R0902: Too many instance attributes (30/7) (too-many-instance-attributes)
filesender.py:101:4: R0914: Too many local variables (16/15) (too-many-locals)
filesender.py:101:4: R0912: Too many branches (41/12) (too-many-branches)
filesender.py:101:4: R0915: Too many statements (174/50) (too-many-statements)
filesender.py:352:4: R0913: Too many arguments (8/5) (too-many-arguments)
filesender.py:352:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
filesender.py:352:4: R0914: Too many local variables (20/15) (too-many-locals)
filesender.py:352:4: R0912: Too many branches (21/12) (too-many-branches)
filesender.py:352:4: R0915: Too many statements (63/50) (too-many-statements)
filesender.py:446:4: R0913: Too many arguments (7/5) (too-many-arguments)
filesender.py:446:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
filesender.py:535:4: R0914: Too many local variables (17/15) (too-many-locals)
filesender.py:577:15: W0718: Catching too general exception Exception (broad-exception-caught)
filesender.py:583:4: R0913: Too many arguments (7/5) (too-many-arguments)
filesender.py:583:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
filesender.py:716:4: R0914: Too many local variables (21/15) (too-many-locals)
filesender.py:853:15: W0718: Catching too general exception Exception (broad-exception-caught)
filesender.py:716:4: R0912: Too many branches (27/12) (too-many-branches)
filesender.py:716:4: R0915: Too many statements (93/50) (too-many-statements)

------------------------------------------------------------------
Your code has been rated at 9.65/10 (previous run: 8.51/10, +1.13)

@madsi1m madsi1m requested a review from monkeyiq March 2, 2026 01:00
@monkeyiq monkeyiq merged commit 066c947 into filesender:development3 Mar 2, 2026
5 checks passed
@madsi1m madsi1m deleted the fscliclient branch March 2, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants