Skip to content

allow hide_sender_email to work as in 2.x again#2545

Merged
monkeyiq merged 3 commits intofilesender:development3from
monkeyiq:2026/feb/hide_sender_d3
Feb 18, 2026
Merged

allow hide_sender_email to work as in 2.x again#2545
monkeyiq merged 3 commits intofilesender:development3from
monkeyiq:2026/feb/hide_sender_d3

Conversation

@monkeyiq
Copy link
Copy Markdown
Contributor

@monkeyiq monkeyiq commented Feb 8, 2026

This was raised in #2537

I have tested this with

  1. no hide_sender_email in transfer_options
  2. adding the following. Note that the advanced option is ignored now as it was being ignored in the 3.x base and I have not moved the option back into the advanced section if it is nominated as advanced.
        'hide_sender_email' => array(
            'available' => true,
            'advanced' => true,
            'default' => true
        ),

Selecting true here will hide the sender email on the download, selecting false will show it.

Selecting to use an email hides this option, selecting to get a link shows the option again. If this is not in transfer_options and you toggle to email and then back to getting a link the option does not start to show up on the upload page.

It feels like there is also a scenario I have not covered in the testing but I think I got the main ones.

@makinog3
Copy link
Copy Markdown
Contributor

makinog3 commented Feb 9, 2026

@monkeyiq Thanks for handling that! I tested the branch, but it had a little problem.
When I don't choose both "An email" and "A transfer link" just after moving to #stage3 on the transfer screen, the hide_sender_email option is displayed. I think the option should be displayed only when choosing "An email" in version 3.x.
And it would be better if the option is displayed just below the sender's email?! (Sorry, I don't know the UI policy)

I will test it more...

@monkeyiq
Copy link
Copy Markdown
Contributor Author

monkeyiq commented Feb 9, 2026

I'm certainly happy to test the scenario that is problematic and adjust. I sort of had the lingering feeling that there might be something that I didn't test in my use cases that is important to a particular deployment (and with a specific configuration).

I am testing on the following config.php fragment. With the hide_sender_email commented out as shown or with the commenting removed. It is also possible, though hopefully unlikely, that this interacts with some other configuration options. I would feel a bit more comfortable updating the PR to honour the advanced selector there to allow the admin to configure where this option should appear.

$config['transfer_options'] = array(
        'email_me_copies' => array(
            'available' => true,
            'advanced' => true,
            'default' => false
        ),
...
        /*
           'hide_sender_email' => array(
            'available' => true,
            'advanced' => true,
            'default' => true
        ),
*/        
...

@monkeyiq
Copy link
Copy Markdown
Contributor Author

When I don't choose both "An email" and "A transfer link" just after moving to #stage3 on the transfer screen, the hide_sender_email option is displayed.

This is a bug. You should always have something selected on the stage3 by default. I have updated things to make that the case again now.

I have also expanded this option to work on "get a link" and "email" so if somebody shares the link from an email the download page should not reveal the email address of the sender. This will not help if the user sends the link directly to a mailing list but if you share the link with $bob and then $bob sends that emailed link to a mailing list then the download page should not show $your email address.

@makinog3
Copy link
Copy Markdown
Contributor

@monkeyiq I agree the option works both "get a link" and "email".
I also tested it with this config. But the option displays outside of the advanced options area now even if advaned=true, right?

        'hide_sender_email' => array(
            'available' => true,
            'advanced' => true,
            'default' => true
        ),

@monkeyiq
Copy link
Copy Markdown
Contributor Author

Yes, at the moment advanced is ignored. Since the option is now being shown and useful on both email and transfer I think I will reenable advanced as an option again so the particular option is not special and will work as a sysadmin expects when setting advanced=true.

@monkeyiq
Copy link
Copy Markdown
Contributor Author

I think I will merge this to be part of release 3.4.

@monkeyiq monkeyiq merged commit 24daab9 into filesender:development3 Feb 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants