allow hide_sender_email to work as in 2.x again#2545
allow hide_sender_email to work as in 2.x again#2545monkeyiq merged 3 commits intofilesender:development3from
Conversation
|
@monkeyiq Thanks for handling that! I tested the branch, but it had a little problem. I will test it more... |
|
I'm certainly happy to test the scenario that is problematic and adjust. I sort of had the lingering feeling that there might be something that I didn't test in my use cases that is important to a particular deployment (and with a specific configuration). I am testing on the following config.php fragment. With the |
This is a bug. You should always have something selected on the stage3 by default. I have updated things to make that the case again now. I have also expanded this option to work on "get a link" and "email" so if somebody shares the link from an email the download page should not reveal the email address of the sender. This will not help if the user sends the link directly to a mailing list but if you share the link with |
|
@monkeyiq I agree the option works both "get a link" and "email". |
|
Yes, at the moment |
|
I think I will merge this to be part of release 3.4. |
This was raised in #2537
I have tested this with
hide_sender_emailin transfer_optionsSelecting
truehere will hide the sender email on the download, selectingfalsewill show it.Selecting to use an email hides this option, selecting to get a link shows the option again. If this is not in transfer_options and you toggle to email and then back to getting a link the option does not start to show up on the upload page.
It feels like there is also a scenario I have not covered in the testing but I think I got the main ones.