fix: Corrected the cgilimit parameter in pagination links to use $limit instead of $cgilimit.#2540
Closed
victoritis wants to merge 1 commit intofilesender:development3from
Closed
Conversation
…limit` instead of `$cgilimit`.
Contributor
|
The issue here is that the key |
Contributor
|
Thank you for the detailed information and PR. I thought it quicker to make and merge the alternate which should also be in development3 now. |
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The single left arrow (previous page) was behaving like the double left arrow (first page), always returning to the beginning instead of going back one page.
Root Cause
The pagination links were using literal strings
cgioffsetandcgilimitinstead of the variables$cgioffsetand$cgilimitin the href URLs.Solution
Changed lines 306-307 in templates/transfers_table.php to use the correct variables, matching the pattern already used in the "next page" button (line 302).
Files Changed